From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40243)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <akong@redhat.com>) id 1XjNRG-0005Ys-6o
	for qemu-devel@nongnu.org; Wed, 29 Oct 2014 03:13:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <akong@redhat.com>) id 1XjNRA-0005kG-1u
	for qemu-devel@nongnu.org; Wed, 29 Oct 2014 03:13:02 -0400
Received: from mx1.redhat.com ([209.132.183.28]:42537)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <akong@redhat.com>) id 1XjNR9-0005kA-Qd
	for qemu-devel@nongnu.org; Wed, 29 Oct 2014 03:12:55 -0400
Date: Wed, 29 Oct 2014 15:12:51 +0800
From: Amos Kong <akong@redhat.com>
Message-ID: <20141029071251.GA30477@air.redhat.com>
References: <1411726999-26513-1-git-send-email-akong@redhat.com>
	<1411727810.865.6.camel@nilsson.home.kraxel.org>
	<20140926105320.GA11893@air.nay.redhat.com>
	<1411730645.865.8.camel@nilsson.home.kraxel.org>
	<20140927032909.GA3029@air>
	<1411981796.32643.13.camel@nilsson.home.kraxel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1411981796.32643.13.camel@nilsson.home.kraxel.org>
Subject: Re: [Qemu-devel] [PATCH v2] ui/input: fix event emitting of
	repeated combined keys
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel@nongnu.org, aliguori@amazon.com, lcapitulino@redhat.com

On Mon, Sep 29, 2014 at 11:09:56AM +0200, Gerd Hoffmann wrote:
>   Hi,
> 
> > It doesn't matter, so users might release the modifier key or not.
> > we should make both works
> > 
> > 1)
> > sendkey Ctrl-Scroll
> > sendkey Ctrl-Scroll
> 
> Good to know this works.
> 
> > 2)
> > sendkey Ctrl-Scroll-Scroll
> 
> Why? 

Quote from http://msdn.microsoft.com/en-us/library/windows/hardware/ff545499(v=vs.85).aspx

 The keyboard crash can be initiated by using the following hotkey
 sequence: _Hold down_ the rightmost CTRL key, and press the SCROLL LOCK
 key twice.

> This tries to squeeze something into the sendkey interface which
> it doesn't was designed for, and IMO this isn't a good idea, especially
> if we have something better at hand (marcelos patch).
 
My patch fixed this problem, but it's a hack. Marcelo's patch works in
(press/release) event level, it's more clear.

Thanks.

> cheers,
>   Gerd
> 

-- 
			Amos.