From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41257) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XjPta-0002xG-AG for qemu-devel@nongnu.org; Wed, 29 Oct 2014 05:50:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XjPtR-0001ah-H7 for qemu-devel@nongnu.org; Wed, 29 Oct 2014 05:50:26 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:52882) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XjPtR-0001aY-Br for qemu-devel@nongnu.org; Wed, 29 Oct 2014 05:50:17 -0400 Date: Wed, 29 Oct 2014 09:50:14 +0000 From: James Hogan Message-ID: <20141029095014.GD7778@jhogan-linux.le.imgtec.org> References: <1414546928-54642-1-git-send-email-yongbok.kim@imgtec.com> <1414546928-54642-2-git-send-email-yongbok.kim@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <1414546928-54642-2-git-send-email-yongbok.kim@imgtec.com> Subject: Re: [Qemu-devel] [PATCH v2 01/20] target-mips: add MSA defines and data structure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yongbok Kim Cc: leon.alrae@imgtec.com, qemu-devel@nongnu.org, aurelien@aurel32.net On Wed, Oct 29, 2014 at 01:41:49AM +0000, Yongbok Kim wrote: > diff --git a/target-mips/cpu.h b/target-mips/cpu.h > index 3b975eb..fb5abda 100644 > --- a/target-mips/cpu.h > +++ b/target-mips/cpu.h > +#define MSACSR_Flags 2 > +#define MSACSR_CEF_MASK (0xffff << MSACSR_Flags) MSACSR_Flags is inconsistently named. Maybe MSACSR_CEF? Otherwise: Reviewed-by: James Hogan Cheers James