From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47826) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XjQSs-0001FT-IL for qemu-devel@nongnu.org; Wed, 29 Oct 2014 06:26:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XjQSl-0004MB-Lt for qemu-devel@nongnu.org; Wed, 29 Oct 2014 06:26:54 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:13555) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XjQSl-0004M7-H7 for qemu-devel@nongnu.org; Wed, 29 Oct 2014 06:26:47 -0400 Date: Wed, 29 Oct 2014 10:26:44 +0000 From: James Hogan Message-ID: <20141029102644.GH7778@jhogan-linux.le.imgtec.org> References: <1414546928-54642-1-git-send-email-yongbok.kim@imgtec.com> <1414546928-54642-6-git-send-email-yongbok.kim@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <1414546928-54642-6-git-send-email-yongbok.kim@imgtec.com> Subject: Re: [Qemu-devel] [PATCH v2 05/20] target-mips: stop translation after ctc1 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yongbok Kim Cc: leon.alrae@imgtec.com, qemu-devel@nongnu.org, aurelien@aurel32.net On Wed, Oct 29, 2014 at 01:41:53AM +0000, Yongbok Kim wrote: > stop translation as ctc1 instruction can change hflags > > Signed-off-by: Yongbok Kim Reviewed-by: James Hogan Cheers James > --- > target-mips/translate.c | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/target-mips/translate.c b/target-mips/translate.c > index 9a8f5c9..b388ba5 100644 > --- a/target-mips/translate.c > +++ b/target-mips/translate.c > @@ -7490,12 +7490,15 @@ static void gen_mttr(CPUMIPSState *env, DisasContext *ctx, int rd, int rt, > break; > case 3: > /* XXX: For now we support only a single FPU context. */ > + save_cpu_state(ctx, 1); > { > TCGv_i32 fs_tmp = tcg_const_i32(rd); > > gen_helper_0e2i(ctc1, t0, fs_tmp, rt); > tcg_temp_free_i32(fs_tmp); > } > + /* Stop translation as we may have changed hflags */ > + ctx->bstate = BS_STOP; > break; > /* COP2: Not implemented. */ > case 4: > @@ -8089,12 +8092,15 @@ static void gen_cp1 (DisasContext *ctx, uint32_t opc, int rt, int fs) > break; > case OPC_CTC1: > gen_load_gpr(t0, rt); > + save_cpu_state(ctx, 1); > { > TCGv_i32 fs_tmp = tcg_const_i32(fs); > > gen_helper_0e2i(ctc1, t0, fs_tmp, rt); > tcg_temp_free_i32(fs_tmp); > } > + /* Stop translation as we may have changed hflags */ > + ctx->bstate = BS_STOP; > opn = "ctc1"; > break; > #if defined(TARGET_MIPS64) > -- > 1.7.4 > >