From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50412) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XjQdh-0000Qk-JH for qemu-devel@nongnu.org; Wed, 29 Oct 2014 06:38:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XjQdc-0008AY-3M for qemu-devel@nongnu.org; Wed, 29 Oct 2014 06:38:05 -0400 Received: from mail-lb0-x229.google.com ([2a00:1450:4010:c04::229]:41820) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XjQdb-0008AJ-Ml for qemu-devel@nongnu.org; Wed, 29 Oct 2014 06:38:00 -0400 Received: by mail-lb0-f169.google.com with SMTP id l4so2191818lbv.14 for ; Wed, 29 Oct 2014 03:37:58 -0700 (PDT) Date: Wed, 29 Oct 2014 10:37:55 +0000 From: Stefan Hajnoczi Message-ID: <20141029103755.GD19774@stefanha-thinkpad.redhat.com> References: <1414404776-4919-1-git-send-email-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="UfEAyuTBtIjiZzX6" Content-Disposition: inline In-Reply-To: <1414404776-4919-1-git-send-email-mreitz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 0/7] block/qcow2: Improve zero cluster expansion List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi --UfEAyuTBtIjiZzX6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 27, 2014 at 11:12:49AM +0100, Max Reitz wrote: > The main purpose of this series is to add a progress report to > qemu-img amend. This is achieved by adding a callback function to > bdrv_amend_options() - the reasons for this choice are explained in > patch 1. >=20 > While adapting qcow2's expand_zero_clusters_in_l1() accordingly, I > noticed a way to simplify it and get rid of the rather ugly bitmap used > there (patch 6). >=20 >=20 > Changes from v3 (v4 is a rebase of v3 on current master) > - Patch 2: There is BlockBackend now (only contextual) > - Patch 4: An instance of g_try_malloc0() instead of g_malloc0() (only > contextual) > - Patch 5: Changes in the qcow2 check functions due to my "qcow2: Fix > image repairing" series (only contextual) > - Patch 6: Originally, contained a hunk which removed a g_malloc0() and > the buffer size calculation before it; now, it's a g_try_malloc0() and > therefore the hunk has to remove the error handling as well. This is a > functional change, but I decided to keep the R-bs anyway because it is > really straightforward. >=20 > Since with the exception of patch 6 all of these were contextual changes > (and the change to patch 6 was really straightforward), I kept all the > Reviewed-bys and this series is therefore still fully reviewed. >=20 >=20 > git-backport-diff against v3: >=20 > Key: > [----] : patches are identical > [####] : number of functional differences between upstream/downstream pat= ch > [down] : patch is downstream-only > The flags [FC] indicate (F)unctional and (C)ontextual differences, respec= tively >=20 > 001/7:[----] [--] 'block: Add status callback to bdrv_amend_options()' > 002/7:[----] [-C] 'qemu-img: Add progress output for amend' > 003/7:[----] [--] 'qemu-img: Fix insignificant memleak' > 004/7:[----] [-C] 'block/qcow2: Implement status CB for amend' > 005/7:[----] [-C] 'block/qcow2: Make get_refcount() global' > 006/7:[0006] [FC] 'block/qcow2: Simplify shared L2 handling in amend' > 007/7:[----] [--] 'iotests: Expand test 061' >=20 >=20 > Max Reitz (7): > block: Add status callback to bdrv_amend_options() > qemu-img: Add progress output for amend > qemu-img: Fix insignificant memleak > block/qcow2: Implement status CB for amend > block/qcow2: Make get_refcount() global > block/qcow2: Simplify shared L2 handling in amend > iotests: Expand test 061 >=20 > block.c | 5 +- > block/qcow2-cluster.c | 117 +++++++++++++++++++++------------------= ------ > block/qcow2-refcount.c | 26 +++++----- > block/qcow2.c | 10 ++-- > block/qcow2.h | 5 +- > include/block/block.h | 8 +++- > include/block/block_int.h | 3 +- > qemu-img-cmds.hx | 4 +- > qemu-img.c | 29 +++++++++-- > qemu-img.texi | 2 +- > tests/qemu-iotests/061 | 25 ++++++++++ > tests/qemu-iotests/061.out | 30 ++++++++++++ > tests/qemu-iotests/group | 2 +- > 13 files changed, 173 insertions(+), 93 deletions(-) >=20 > --=20 > 1.9.3 >=20 >=20 Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan --UfEAyuTBtIjiZzX6 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUUMODAAoJEJykq7OBq3PIkecH/2lqiks1iIvZ7i2+9ncBJMaH 9frPnYv+f0+GE1CXmqpZOjSRQtlyZueNqbHVTxcoBVpt97oHTcIHtCC4y8qJKVly jerWauicydUK9R8qiN4y9TWSyFcyfrjbZF5TohojobtzD+uJn6/B81lzkFT6CDCi R0O20eX+QRtrQ9nS9A5NaFL5mKC5+/hN6K2QKfGaksVPfN2aEQru4u36NrpuNwPN PbLT/6IX4tia4WuFXMt/dN7tOe4oQ9SLzbnqFxEJjso2BbcMt5xxA5At5M06cK/3 nEZ2lccqkdRGUKuFwlIqg8i3zNq0Nyhi38lxBvT/PVVltfQ/3HJmXP0jfJOLk7I= =T20N -----END PGP SIGNATURE----- --UfEAyuTBtIjiZzX6--