From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48868) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XjUGO-0008No-4z for qemu-devel@nongnu.org; Wed, 29 Oct 2014 10:30:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XjUGH-0007cs-E8 for qemu-devel@nongnu.org; Wed, 29 Oct 2014 10:30:16 -0400 Received: from mail-lb0-f172.google.com ([209.85.217.172]:52967) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XjUGH-0007cR-7V for qemu-devel@nongnu.org; Wed, 29 Oct 2014 10:30:09 -0400 Received: by mail-lb0-f172.google.com with SMTP id n15so2595213lbi.17 for ; Wed, 29 Oct 2014 07:30:07 -0700 (PDT) Date: Wed, 29 Oct 2014 14:30:03 +0000 From: Stefan Hajnoczi Message-ID: <20141029143003.GC5218@stefanha-thinkpad.redhat.com> References: <1414569232-21357-1-git-send-email-hare@suse.de> <1414569232-21357-2-git-send-email-hare@suse.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Izn7cH1Com+I3R9J" Content-Disposition: inline In-Reply-To: <1414569232-21357-2-git-send-email-hare@suse.de> Subject: Re: [Qemu-devel] [PATCH 01/17] ahci: Fix CD-ROM signature List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hannes Reinecke Cc: Paolo Bonzini , Alexander Graf , qemu-devel@nongnu.org, Andreas Faerber , Nic Bellinger --Izn7cH1Com+I3R9J Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 29, 2014 at 08:53:36AM +0100, Hannes Reinecke wrote: > The CD-ROM signature is 0xeb140101, not 0xeb140000. > Without this change OVMF/Duet runs into a timeout trying > to detect a SATA cdrom. >=20 > Signed-off-by: Hannes Reinecke > --- > hw/ide/ahci.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/hw/ide/ahci.h b/hw/ide/ahci.h > index e223258..970eea8 100644 > --- a/hw/ide/ahci.h > +++ b/hw/ide/ahci.h > @@ -161,7 +161,7 @@ > #define AHCI_CMD_HDR_CMD_FIS_LEN 0x1f > #define AHCI_CMD_HDR_PRDT_LEN 16 > =20 > -#define SATA_SIGNATURE_CDROM 0xeb140000 > +#define SATA_SIGNATURE_CDROM 0xeb140101 Looks good, this change is justified by ATA/ATAPI-4 "9.1 Signature and persistence". Reviewed-by: Stefan Hajnoczi --Izn7cH1Com+I3R9J Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUUPnrAAoJEJykq7OBq3PIF7cH/RJfrVuFKGBuQrIPEvFMot0f Bj/zyp2noKphY4XxbFg79jNWydiQNvNgkXrjeGrVNGFgNypo91lndWb9FI0nOwyr 2pH8uVaz9o9Zf89pdEYAyqmaNLJs+b8/pZqjF8dbgrol8dYrGyooDBVCvhY07XdM bP3aJrqmBie51AzLbwAjoxMk5PZ1fKf6QTpATVQS64YxCUWLKEwogH72lQp9odSl Zbm4x/iIZkByFmrmDwch1jkuaIzvr5MtKQfw4GzOsMVfoLwvk+H/0kCDlOLCYtLy VGo1WkD7cK4dX6MVwWxpQzqpFf/M9Hn2J2qG4D8osPNuFV55juLhnkNVmeif/MY= =/CLW -----END PGP SIGNATURE----- --Izn7cH1Com+I3R9J--