From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Amit Shah <amit.shah@redhat.com>
Cc: quintela@redhat.com, qemu-devel@nongnu.org, ehabkost@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/3] Start moving migration code into a migration directory
Date: Thu, 30 Oct 2014 12:37:27 +0000 [thread overview]
Message-ID: <20141030123727.GI2376@work-vm> (raw)
In-Reply-To: <20141030122859.GB19349@grmbl.mre>
* Amit Shah (amit.shah@redhat.com) wrote:
> On (Thu) 16 Oct 2014 [08:53:52], Dr. David Alan Gilbert (git) wrote:
>
> > rename migration-exec.c => migration/migration-exec.c (100%)
> > rename migration-fd.c => migration/migration-fd.c (100%)
> > rename migration-rdma.c => migration/migration-rdma.c (100%)
> > rename migration-tcp.c => migration/migration-tcp.c (100%)
> > rename migration-unix.c => migration/migration-unix.c (100%)
> > rename migration.c => migration/migration.c (100%)
>
> I'm wondering if we should also use the opportunity to cleanup the
> file names:
>
> migration.c => main.c
> migration-X.c => X.c
>
> ?
I'd be OK with changing filenames, but they would have to
be fairly clear; I don't like having a 'main.c' because that's
where I'd expect to find a main() - but we do have a few core.c's
as the core of each of a few hw subdirs.
Dave
>
> Amit
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2014-10-31 15:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-16 7:53 [Qemu-devel] [PATCH 0/3] More migration file cleanup Dr. David Alan Gilbert (git)
2014-10-16 7:53 ` [Qemu-devel] [PATCH 1/3] Start moving migration code into a migration directory Dr. David Alan Gilbert (git)
2014-10-16 8:08 ` Juan Quintela
2014-10-16 8:12 ` Dr. David Alan Gilbert
2014-10-20 18:34 ` Paolo Bonzini
2014-10-16 8:08 ` Juan Quintela
2014-10-30 12:26 ` Amit Shah
2014-10-31 21:08 ` Gary Hook
2014-11-03 8:53 ` Dr. David Alan Gilbert
2014-11-03 12:32 ` Eduardo Habkost
2014-10-30 12:28 ` Amit Shah
2014-10-30 12:37 ` Dr. David Alan Gilbert [this message]
2014-10-30 12:46 ` Amit Shah
2014-10-31 23:31 ` Peter Maydell
2014-10-31 18:32 ` Peter Maydell
2014-10-31 18:58 ` Dr. David Alan Gilbert
2014-10-16 7:53 ` [Qemu-devel] [PATCH 2/3] Split struct QEMUFile out Dr. David Alan Gilbert (git)
2014-10-16 8:09 ` Juan Quintela
2014-10-30 12:34 ` Amit Shah
2014-10-16 7:53 ` [Qemu-devel] [PATCH 3/3] Split the QEMU buffered file code out Dr. David Alan Gilbert (git)
2014-10-16 8:10 ` Juan Quintela
2014-10-30 12:35 ` Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141030123727.GI2376@work-vm \
--to=dgilbert@redhat.com \
--cc=amit.shah@redhat.com \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).