From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44044) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XkES1-0005ea-SF for qemu-devel@nongnu.org; Fri, 31 Oct 2014 11:50:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xjoyq-0000sB-Gj for qemu-devel@nongnu.org; Thu, 30 Oct 2014 08:37:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60490) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xjoyq-0000rz-9t for qemu-devel@nongnu.org; Thu, 30 Oct 2014 08:37:32 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9UCbVXE016907 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 30 Oct 2014 08:37:31 -0400 Date: Thu, 30 Oct 2014 12:37:27 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20141030123727.GI2376@work-vm> References: <1413446034-25167-1-git-send-email-dgilbert@redhat.com> <1413446034-25167-2-git-send-email-dgilbert@redhat.com> <20141030122859.GB19349@grmbl.mre> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141030122859.GB19349@grmbl.mre> Subject: Re: [Qemu-devel] [PATCH 1/3] Start moving migration code into a migration directory List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah Cc: quintela@redhat.com, qemu-devel@nongnu.org, ehabkost@redhat.com * Amit Shah (amit.shah@redhat.com) wrote: > On (Thu) 16 Oct 2014 [08:53:52], Dr. David Alan Gilbert (git) wrote: > > > rename migration-exec.c => migration/migration-exec.c (100%) > > rename migration-fd.c => migration/migration-fd.c (100%) > > rename migration-rdma.c => migration/migration-rdma.c (100%) > > rename migration-tcp.c => migration/migration-tcp.c (100%) > > rename migration-unix.c => migration/migration-unix.c (100%) > > rename migration.c => migration/migration.c (100%) > > I'm wondering if we should also use the opportunity to cleanup the > file names: > > migration.c => main.c > migration-X.c => X.c > > ? I'd be OK with changing filenames, but they would have to be fairly clear; I don't like having a 'main.c' because that's where I'd expect to find a main() - but we do have a few core.c's as the core of each of a few hw subdirs. Dave > > Amit -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK