From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37946) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XkERk-0005Vv-Jw for qemu-devel@nongnu.org; Fri, 31 Oct 2014 11:49:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xjp7b-0003Qy-Gy for qemu-devel@nongnu.org; Thu, 30 Oct 2014 08:46:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41264) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xjp7b-0003Qt-9a for qemu-devel@nongnu.org; Thu, 30 Oct 2014 08:46:35 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9UCkYvc021887 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 30 Oct 2014 08:46:34 -0400 Date: Thu, 30 Oct 2014 18:16:27 +0530 From: Amit Shah Message-ID: <20141030124627.GA21242@grmbl.mre> References: <1413446034-25167-1-git-send-email-dgilbert@redhat.com> <1413446034-25167-2-git-send-email-dgilbert@redhat.com> <20141030122859.GB19349@grmbl.mre> <20141030123727.GI2376@work-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141030123727.GI2376@work-vm> Subject: Re: [Qemu-devel] [PATCH 1/3] Start moving migration code into a migration directory List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: quintela@redhat.com, qemu-devel@nongnu.org, ehabkost@redhat.com On (Thu) 30 Oct 2014 [12:37:27], Dr. David Alan Gilbert wrote: > * Amit Shah (amit.shah@redhat.com) wrote: > > On (Thu) 16 Oct 2014 [08:53:52], Dr. David Alan Gilbert (git) wrote: > > > > > rename migration-exec.c => migration/migration-exec.c (100%) > > > rename migration-fd.c => migration/migration-fd.c (100%) > > > rename migration-rdma.c => migration/migration-rdma.c (100%) > > > rename migration-tcp.c => migration/migration-tcp.c (100%) > > > rename migration-unix.c => migration/migration-unix.c (100%) > > > rename migration.c => migration/migration.c (100%) > > > > I'm wondering if we should also use the opportunity to cleanup the > > file names: > > > > migration.c => main.c > > migration-X.c => X.c > > > > ? > > I'd be OK with changing filenames, but they would have to > be fairly clear; I don't like having a 'main.c' because that's > where I'd expect to find a main() - but we do have a few core.c's > as the core of each of a few hw subdirs. I think main should be OK in a subdir, because it's the main file for that subsystem (not necessarily the whole program). Checking the src for main.c, though, it looks like no one uses it in such a way (Linux has lots of these, btw, hence my initial suggestion). core.c is fine, too. Amit