From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41509) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XkE71-0002DX-Rc for qemu-devel@nongnu.org; Fri, 31 Oct 2014 11:30:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XjwbK-0002kP-Vg for qemu-devel@nongnu.org; Thu, 30 Oct 2014 16:45:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50564) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XjwbK-0002k5-OM for qemu-devel@nongnu.org; Thu, 30 Oct 2014 16:45:46 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9UKjiOI009363 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 30 Oct 2014 16:45:44 -0400 Date: Thu, 30 Oct 2014 20:45:42 +0000 From: "Richard W.M. Jones" Message-ID: <20141030204542.GB14637@redhat.com> References: <1414512220-19058-1-git-send-email-armbru@redhat.com> <1414512220-19058-3-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1414512220-19058-3-git-send-email-armbru@redhat.com> Subject: Re: [Qemu-devel] [PATCH RFC 2/2] block: Warn on insecure format probing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com Can you add something like: -drive ...,format=unsafe-probe so it does the probing anyway, even though we know it's unsafe? This will minimize the churn needed in libguestfs to make this work. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into KVM guests. http://libguestfs.org/virt-v2v