* [Qemu-devel] [PATCH] target-i386: Remove unused model_features_t struct
@ 2014-10-30 19:12 Eduardo Habkost
2014-10-31 8:55 ` Igor Mammedov
2014-11-02 4:57 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
0 siblings, 2 replies; 3+ messages in thread
From: Eduardo Habkost @ 2014-10-30 19:12 UTC (permalink / raw)
To: qemu-devel, qemu-trivial; +Cc: Igor Mammedov, Andreas Färber
The struct is not used anymore and can be removed.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
target-i386/cpu.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index e194601..e4ccee1 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -442,14 +442,6 @@ const char *get_register_name_32(unsigned int reg)
return x86_reg_info_32[reg].name;
}
-/* collects per-function cpuid data
- */
-typedef struct model_features_t {
- uint32_t *guest_feat;
- uint32_t *host_feat;
- FeatureWord feat_word;
-} model_features_t;
-
/* KVM-specific features that are automatically added to all CPU models
* when KVM is enabled.
*/
--
1.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] target-i386: Remove unused model_features_t struct
2014-10-30 19:12 [Qemu-devel] [PATCH] target-i386: Remove unused model_features_t struct Eduardo Habkost
@ 2014-10-31 8:55 ` Igor Mammedov
2014-11-02 4:57 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
1 sibling, 0 replies; 3+ messages in thread
From: Igor Mammedov @ 2014-10-31 8:55 UTC (permalink / raw)
To: Eduardo Habkost; +Cc: qemu-trivial, qemu-devel, Andreas Färber
On Thu, 30 Oct 2014 17:12:33 -0200
Eduardo Habkost <ehabkost@redhat.com> wrote:
> The struct is not used anymore and can be removed.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> target-i386/cpu.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index e194601..e4ccee1 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -442,14 +442,6 @@ const char *get_register_name_32(unsigned int reg)
> return x86_reg_info_32[reg].name;
> }
>
> -/* collects per-function cpuid data
> - */
> -typedef struct model_features_t {
> - uint32_t *guest_feat;
> - uint32_t *host_feat;
> - FeatureWord feat_word;
> -} model_features_t;
> -
> /* KVM-specific features that are automatically added to all CPU models
> * when KVM is enabled.
> */
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] target-i386: Remove unused model_features_t struct
2014-10-30 19:12 [Qemu-devel] [PATCH] target-i386: Remove unused model_features_t struct Eduardo Habkost
2014-10-31 8:55 ` Igor Mammedov
@ 2014-11-02 4:57 ` Michael Tokarev
1 sibling, 0 replies; 3+ messages in thread
From: Michael Tokarev @ 2014-11-02 4:57 UTC (permalink / raw)
To: Eduardo Habkost, qemu-devel, qemu-trivial
Cc: Igor Mammedov, Andreas Färber
30.10.2014 22:12, Eduardo Habkost wrote:
> The struct is not used anymore and can be removed.
Applied to -trivial, thank you!
/mjt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-11-02 4:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-30 19:12 [Qemu-devel] [PATCH] target-i386: Remove unused model_features_t struct Eduardo Habkost
2014-10-31 8:55 ` Igor Mammedov
2014-11-02 4:57 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).