From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37992) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XkDlm-0005aG-PC for qemu-devel@nongnu.org; Fri, 31 Oct 2014 11:06:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xk9vx-0006YV-PT for qemu-devel@nongnu.org; Fri, 31 Oct 2014 07:00:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59321) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xk9vx-0006XA-Ht for qemu-devel@nongnu.org; Fri, 31 Oct 2014 06:59:57 -0400 Date: Fri, 31 Oct 2014 10:59:47 +0000 From: Stefan Hajnoczi Message-ID: <20141031105947.GB10332@stefanha-thinkpad.redhat.com> References: <1414256153-10148-1-git-send-email-pl@kamp.de> <1414256153-10148-4-git-send-email-pl@kamp.de> <20141028111148.GF19211@stefanha-thinkpad.redhat.com> <545348F9.4050508@kamp.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="hQiwHBbRI9kgIhsi" Content-Disposition: inline In-Reply-To: <545348F9.4050508@kamp.de> Subject: Re: [Qemu-devel] [PATCHv3 3/6] block: add a knob to disable multiwrite_merge List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven Cc: kwolf@redhat.com, famz@redhat.com, benoit@irqsave.net, armbru@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com --hQiwHBbRI9kgIhsi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 31, 2014 at 09:31:53AM +0100, Peter Lieven wrote: > Am 28.10.2014 um 12:11 schrieb Stefan Hajnoczi: > > On Sat, Oct 25, 2014 at 06:55:50PM +0200, Peter Lieven wrote: > > The big question is whether these user-visible interfaces make sense if > > write merging will be moved from block.c into virtio-blk.c in the > > future. Once an interface has been added it cannot be removed. >=20 > Would you make it a feature of the virtio-blk-pci device then? No, I myself feel that it is a generic feature and moving it into the storage controller emulation code would be a step backwards. Stefan --hQiwHBbRI9kgIhsi Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUU2ujAAoJEJykq7OBq3PIrhYH/jV+guSdqYeWFho0kFrZZJdc QjsDa6i9t+WOMKGsb4JGE51P8ClUEAKJ1ttI2t93OMjTRr6NxFfX8Ar1/MxaIMeU Lij7JXCjZJMm/gvNQCq3YAb1Xm59x4QJ5BhSmqWuDNg+0RGEb5vJA+Furo1yiGxd su7ohthG8aOosGKMkFZ+bjg14k9tZa3glX6eBCVpirae+FxgFnanpuNwXfVOD5Jv NPyreBH6oP6IuCxnFMg8jsAl3sORK03awTaI7dnYxyiTbxRg1PTCm/ataYDx+nOx KKMFhAQJhpHDj8vVwzW7ghvrLPIoFL3JJSmJHq9I2plS4rPMW84KtAYcuPfhAOs= =V5tL -----END PGP SIGNATURE----- --hQiwHBbRI9kgIhsi--