From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55840) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xl8Tv-0002Mx-2J for qemu-devel@nongnu.org; Sun, 02 Nov 2014 22:39:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xl8Tq-0007ME-Hz for qemu-devel@nongnu.org; Sun, 02 Nov 2014 22:39:03 -0500 Received: from ozlabs.org ([2401:3900:2:1::2]:42855) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xl8Tq-0007LE-6z for qemu-devel@nongnu.org; Sun, 02 Nov 2014 22:38:58 -0500 Date: Mon, 3 Nov 2014 13:34:01 +1100 From: David Gibson Message-ID: <20141103023401.GB8949@voom.redhat.com> References: <1412358473-31398-1-git-send-email-dgilbert@redhat.com> <1412358473-31398-5-git-send-email-dgilbert@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="98e8jtXdkpgskNou" Content-Disposition: inline In-Reply-To: <1412358473-31398-5-git-send-email-dgilbert@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 04/47] qemu_ram_foreach_block: pass up error value, and down the ramblock name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, lilei@linux.vnet.ibm.com, quintela@redhat.com, cristian.klein@cs.umu.se, qemu-devel@nongnu.org, amit.shah@redhat.com, yanghy@cn.fujitsu.com --98e8jtXdkpgskNou Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 03, 2014 at 06:47:10PM +0100, Dr. David Alan Gilbert (git) wrot= e: > From: "Dr. David Alan Gilbert" >=20 > check the return value of the function it calls and error if it's non-0 > Fixup qemu_rdma_init_one_block that is the only current caller, > and __qemu_rdma_add_block the only function it calls using it. >=20 > Pass the name of the ramblock to the function; helps in debugging. >=20 > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: David Gibson --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --98e8jtXdkpgskNou Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUVumZAAoJEGw4ysog2bOSFaMQAIzJsEriV4ppaMYh47fV9LC0 pTjNBo/dBcyDWPTnd2NhILbE3uO9lh+B6LmgCEXQAHOq41RpE0eF1YMEmvhnKXmD uNSloK1gxNCPlyMQ2kgjd3qcMivhsbrkgpM9V/cOoGLdH6SHzQdYZ61LLtXWHjjK 5oq9fcOHjc7zQK2Rm250Uj2rmTD4ZSnOhYH5eR22mF8EMXPw/koVP5Zx65B1k78k Hw3k+zc4NtVnhXXQNKJViAYihJd9lk6Owu8rkuV1dFfqJVOu4BZ0uekRKmub7hjd L6tOQ2yjwZwk7r3nSt4+UYl0DXUuAfrqi/8KqAJcaqT4wPpge+Wa68oDh1+n4lwY 8zczgdS8jRgKdebbCJtwO+psMbFkiiZZlc32jLvssDbWW/HHWPinJAVJZzPt4aWF jUR8prbX3iu1ULes7qtjD7Ja0YMo5z9t4wo0HSzcl83emcDegHv3mDuLvaPvpcKb uKjxn6YlgKH1ekOlGFcmpsQO4OTLq83kE/dAqTRbBcBJUNebjDZeYJLlVyRVN+Ew uByOZe7QjQGPvNcqFj05cz2+l59LUFRqzF2wDpSGYBfBQ+LPFrX915wySC53FdSg rDQERiwj5ylGNzEtnTlePlPS3jBFD9hTWMoLwbhdnQEWiHc1/Eavg/MtN354uyWf ReerBUzciwAIghgaN4/D =5b0z -----END PGP SIGNATURE----- --98e8jtXdkpgskNou--