From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55880) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xl8Tw-0002NW-OT for qemu-devel@nongnu.org; Sun, 02 Nov 2014 22:39:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xl8Tq-0007M6-Hh for qemu-devel@nongnu.org; Sun, 02 Nov 2014 22:39:04 -0500 Received: from ozlabs.org ([103.22.144.67]:45506) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xl8Tq-0007LP-79 for qemu-devel@nongnu.org; Sun, 02 Nov 2014 22:38:58 -0500 Date: Mon, 3 Nov 2014 13:45:24 +1100 From: David Gibson Message-ID: <20141103024524.GE8949@voom.redhat.com> References: <1412358473-31398-1-git-send-email-dgilbert@redhat.com> <1412358473-31398-8-git-send-email-dgilbert@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="jKBxcB1XkHIR0Eqt" Content-Disposition: inline In-Reply-To: <1412358473-31398-8-git-send-email-dgilbert@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 07/47] Create MigrationIncomingState List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, lilei@linux.vnet.ibm.com, quintela@redhat.com, cristian.klein@cs.umu.se, qemu-devel@nongnu.org, amit.shah@redhat.com, yanghy@cn.fujitsu.com --jKBxcB1XkHIR0Eqt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 03, 2014 at 06:47:13PM +0100, Dr. David Alan Gilbert (git) wrot= e: > From: "Dr. David Alan Gilbert" >=20 > There are currently lots of pieces of incoming migration state scattered > around, and postcopy is adding more, and it seems better to try and keep > it together. >=20 > allocate MIS in process_incoming_migration_co >=20 > Signed-off-by: Dr. David Alan Gilbert > --- > include/migration/migration.h | 9 +++++++++ > include/qemu/typedefs.h | 2 ++ > migration.c | 28 ++++++++++++++++++++++++++++ > savevm.c | 2 ++ > 4 files changed, 41 insertions(+) >=20 > diff --git a/include/migration/migration.h b/include/migration/migration.h > index 3cb5ba8..8a36255 100644 > --- a/include/migration/migration.h > +++ b/include/migration/migration.h > @@ -41,6 +41,15 @@ struct MigrationParams { > =20 > typedef struct MigrationState MigrationState; > =20 > +/* State for the incoming migration */ > +struct MigrationIncomingState { > + QEMUFile *file; > +}; > + > +MigrationIncomingState *migration_incoming_get_current(void); > +MigrationIncomingState *migration_incoming_state_init(QEMUFile *f); Hrm. I'd prefer to see this called migration_incoming_state_new(), since it allocates a new structure, rather than just initializing an already allocated one. I guess you're trying to match migrate_init() in name, so i guess migrate_incoming_init() would work as well. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --jKBxcB1XkHIR0Eqt Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUVuxEAAoJEGw4ysog2bOS5ooP/1heENmC7ADPzOZdkq4qUWez YjNi7J4HsVSSgxE3WhwI/FlqZ8NlLnMgwsh3VgaoUN9WxKCA59CXluXUF9eWLAbq 9R+Xv/99Bsu+jbZ3xVZ1qR8NXHqf649YT2x91Ya0e2XwoUCYTo5eNJwG5hcvJUus Ivegb6I8374PmmJxQWGY1rLYUwj2jod+P2iBTuOFRaC1JjvP+DGRxJDzGS9LFYSK 5idb4NJ/vRvZJDECo2MQzsRLMkeClgRD52c3tBJ+auaIgx+hm1buAGnU6xvuLvsA CtQUrBEe/JVnxXro3AzHH0BtI/ApKmXt42hzRkVQFah4VKa9SCDLqIpsx7pdLwyg MRrujHLLcgXIcaFhTKzuoJB+foY+3/DJOTFUZ1mybiPk4l/QxqYVyeI/AYU9H6Up H0WVqMeXrUMY8ZrAfrTFxeChcaxDJ/nBh26pFn+1hMPd1OLRuroj2Z3+W2+gmuTF sfqa5uB03DcGjQrXuUA60KSVfBaasllMc1blDicsnSLib0AZHJxBMVlOgpTuexrR 0CMKGPrvWF6TRX5WTHnDSHZxw8jjyrKLkyJnq19T1YK9zPJ7GAAZbhUjFEg+Zmfy hijC3ETcpC0koi6PWMlncq3mWne6p53ffmM/JhVT491A4vkjF/R/E81pFmGsnoyG qmYrUpJcOITfIu7R2HXE =aVky -----END PGP SIGNATURE----- --jKBxcB1XkHIR0Eqt--