From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36000) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xl9by-0004sk-M2 for qemu-devel@nongnu.org; Sun, 02 Nov 2014 23:51:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xl9bj-0001HH-LS for qemu-devel@nongnu.org; Sun, 02 Nov 2014 23:51:26 -0500 Received: from ozlabs.org ([103.22.144.67]:39690) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xl9bj-0001Go-94 for qemu-devel@nongnu.org; Sun, 02 Nov 2014 23:51:11 -0500 Date: Mon, 3 Nov 2014 14:46:00 +1100 From: David Gibson Message-ID: <20141103034600.GL8949@voom.redhat.com> References: <1412358473-31398-1-git-send-email-dgilbert@redhat.com> <1412358473-31398-17-git-send-email-dgilbert@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="KSn4sQg3MnruwCB4" Content-Disposition: inline In-Reply-To: <1412358473-31398-17-git-send-email-dgilbert@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 16/47] Return path: Source handling of return path List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, lilei@linux.vnet.ibm.com, quintela@redhat.com, cristian.klein@cs.umu.se, qemu-devel@nongnu.org, amit.shah@redhat.com, yanghy@cn.fujitsu.com --KSn4sQg3MnruwCB4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 03, 2014 at 06:47:22PM +0100, Dr. David Alan Gilbert (git) wrot= e: > From: "Dr. David Alan Gilbert" >=20 > Open a return path, and handle messages that are received upon it. >=20 > Signed-off-by: Dr. David Alan Gilbert [snip] > @@ -414,6 +448,11 @@ static void migrate_fd_cancel(MigrationState *s) > int old_state ; > trace_migrate_fd_cancel(); > =20 > + if (s->return_path) { > + /* shutdown the rp socket, so causing the rp thread to shutdown = */ > + qemu_file_shutdown(s->return_path); Terminating the rp thread via shutting down its file seems roundabout, and kind of dependent on the socket file implementation. [snip] > +__attribute__ (( unused )) /* Until later in patch series */ > +static int open_outgoing_return_path(MigrationState *ms) > +{ > + > + ms->return_path =3D qemu_file_get_return_path(ms->file); So, another reason this get_return_path abstraction doesn't seem right to me, is that it's not obvious that for non-socket file types, the source and destination side "get return path" operations would necessarily be the same. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --KSn4sQg3MnruwCB4 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUVvp4AAoJEGw4ysog2bOSODQP/RfSICngWBF3wcdmssSSviIq rL8azfTtQ/hO+Tv1tnGsrM6PDuHh4JAkRKB/rkyiQtDr3i4dv3f9b9C+R7QW2qD3 Wl18oK7DC9wrDjfxq/4Mon+qvmzy0P+1evam5kCGOounGLnaCloS2BrohwzYdJIE 7r7alKH35naxVX7NRddWCDX0GnSVinsoS34y+jzp9p+t17lnFpkMHFLRnKdx2+Tk K35T8MV6wJB+CxIKlGW9NQm6oyzgizdemz6gwjJoeyeEDwBWgYfelBqW11+mn5nM oTCllCCKRdXoui0Z0BG24myZPllDT8ChXyBtMehzKM78M3TTddm4rbq1OQpBVZgO Rs36kbYh9AEymHlJlvXyKY9priqetYwtPNK8VgrwYe6NVdZWfwXIcqWs9oWENzRt epsXxVSG1JjO/4Qtoz1mMHDO44ndYzb3rEF1hWkzBQvAWVjREkkLN7soJLftKESZ etedweo+mShZwvD7NEjb4aLDOApZ4hUfgZmwH6z8eAwoeV0MIqzGt9z4DPNwO0rK ro7DfBqkq4hTBpKUnTcXI/RDP1lNREA2xn1s/PnQ6/kZxxXQbjk2PvnpDpUMpcF1 Z7Nij9zlQxTncr9Qkef/Xyp3wKhirByAUVcehi4s4QEr6LFxpe3k6mHIp+VhzY0g n1mFlsUc/w6vxRG2z0Us =sGxA -----END PGP SIGNATURE----- --KSn4sQg3MnruwCB4--