From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35988) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xl9bo-0004d9-SL for qemu-devel@nongnu.org; Sun, 02 Nov 2014 23:51:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xl9bj-0001HP-Lz for qemu-devel@nongnu.org; Sun, 02 Nov 2014 23:51:16 -0500 Received: from ozlabs.org ([2401:3900:2:1::2]:59758) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xl9bj-0001Gq-91 for qemu-devel@nongnu.org; Sun, 02 Nov 2014 23:51:11 -0500 Date: Mon, 3 Nov 2014 14:47:46 +1100 From: David Gibson Message-ID: <20141103034746.GM8949@voom.redhat.com> References: <1412358473-31398-1-git-send-email-dgilbert@redhat.com> <1412358473-31398-17-git-send-email-dgilbert@redhat.com> <543F814F.6030105@huawei.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="5fECsWged6836Ycf" Content-Disposition: inline In-Reply-To: <543F814F.6030105@huawei.com> Subject: Re: [Qemu-devel] [PATCH v4 16/47] Return path: Source handling of return path List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: zhanghailiang Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, lilei@linux.vnet.ibm.com, quintela@redhat.com, cristian.klein@cs.umu.se, "Dr. David Alan Gilbert (git)" , qemu-devel@nongnu.org, amit.shah@redhat.com, yanghy@cn.fujitsu.com --5fECsWged6836Ycf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 16, 2014 at 04:26:55PM +0800, zhanghailiang wrote: > On 2014/10/4 1:47, Dr. David Alan Gilbert (git) wrote: > >From: "Dr. David Alan Gilbert" [snip] > >+ case MIG_RPCOMM_ACK: > >+ tmp32 =3D be32_to_cpup((uint32_t *)buf); > >+ DPRINTF("RP: Received ACK 0x%x", tmp32); > >+ atomic_xchg(&ms->rp_state.latest_ack, tmp32); >=20 > I didn't see *ms->rp_state.latest_ack* been used elsewhere, what's it use= d for?;) Also, you don't appear to use tmp32 after that point, so what's the reason for the exchange, rather than just an assignment? --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --5fECsWged6836Ycf Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUVvriAAoJEGw4ysog2bOSBEUP/iw5tX0sS7ptHM8uhtWhdAxk 4rL7GT+rnVtDsu0zxmaRIvru/ouGcNgPQQ4QC564Auit1WZtcRUTp+GT1kJdncV1 HFIa9bl0lj6O69VeNgLx54RdbIwBXpoHw5fYeRlaKeb+JoTnJSCw99tufqYknmu4 x1C91yYBBrQ58mR1/zzJ6+spahwAJHmY4+NibCSKKGEeCYGdx3I6p9QXVW3dZsat baTi+oytG3VYGBeLM0riAecTqAVI1codogookrs3GMXFrHXTtD4+KS9y9rU+wTtN aLkSPJarf7C0Xdlrqm+geOaHoAdRtN7UboBTB9EiVYEPx5YGsgRdSep5SR0IuHrQ M+RDN17WG0wYbiulfP/lCRlLEZ/Ps+9nazM6rL7PARYVXpf8yrhxreF+jcC/ipOy kOBGECiFgJXhOLn3Uv+xskmawsmpy7SWOGy/hqspVKHJu820PsuwxyKnJYfuP5A4 ZFW8zgXB/LLWG7iirpuT66BRIAldPbD1KCYaGlOKImgqh9lK0vHYDxRZYq0EqtKV UANLAmW8i1cdoIboNfo0f4nXKKwxJImM28FwHKn49FVjZCC3LpOBPYBKL1rPL8VG sGDkk8SrMwkguTZAU0Cva809z6+oR1oQNAwI3BMk7CQEibLiXCTDg6V+BvzD8zE0 N6OobZe570YVeTW9Jy8F =lobb -----END PGP SIGNATURE----- --5fECsWged6836Ycf--