From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50953) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlDOp-0006kY-4n for qemu-devel@nongnu.org; Mon, 03 Nov 2014 03:54:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XlDOj-0002Pu-Rk for qemu-devel@nongnu.org; Mon, 03 Nov 2014 03:54:07 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54297) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlDOj-0002Pi-Dn for qemu-devel@nongnu.org; Mon, 03 Nov 2014 03:54:01 -0500 Date: Mon, 3 Nov 2014 08:53:54 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20141103085353.GA3480@work-vm> References: <1413446034-25167-1-git-send-email-dgilbert@redhat.com> <1413446034-25167-2-git-send-email-dgilbert@redhat.com> <20141030122652.GA19349@grmbl.mre> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH 1/3] Start moving migration code into a migration directory List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gary Hook Cc: "qemu-devel@nongnu.org" , "ehabkost@redhat.com" , "quintela@redhat.com" * Gary Hook (gary.hook@nimboxx.com) wrote: > > > On 10/30/14, 7:26 AM, "Amit Shah" wrote: > > >On (Thu) 16 Oct 2014 [08:53:52], Dr. David Alan Gilbert (git) wrote: > >> From: "Dr. David Alan Gilbert" > >> > >> The migration code now occupies a fair chunk of the top level .c > >> files, it seems time to give it it's own directory. > > > >s/it's/its > > 6 out of 87 .c files, and approximately 370 blocks out of 2840 (based on > du output). 13% is a "fair chunk"? I'm not sure how you got 6; migration.c migration-exec.c migration-fd.c migration-rdma.c migration-tcp.c migration-unix.c qemu-file-buf.c qemu-file.c qemu-file-stdio.c qemu-file-unix.c vmstate.c xbzrle.c so that's 12, and there are another 3 in the commit message saying they could do with being moved. That would be 15 files, or 17% - and so yes, I do call that a fair chunk. > But tidy organization is a good thing while needless renaming is not. The > only goal that the suggested renames would appear to accomplish is > additional obfuscation. How about just moving them into a subdirectory and > leave their names alone? Which is what I did; however I have sympathy with those that think that in a directory called 'migration' starting a bunch of the files with 'migration-' is excessive. Dave -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK