From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35280) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlG0x-0007fz-Aj for qemu-devel@nongnu.org; Mon, 03 Nov 2014 06:41:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XlG0o-0005bY-85 for qemu-devel@nongnu.org; Mon, 03 Nov 2014 06:41:39 -0500 Received: from mail-la0-x235.google.com ([2a00:1450:4010:c03::235]:55706) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlG0n-0005bB-T1 for qemu-devel@nongnu.org; Mon, 03 Nov 2014 06:41:30 -0500 Received: by mail-la0-f53.google.com with SMTP id mc6so9179957lab.26 for ; Mon, 03 Nov 2014 03:41:27 -0800 (PST) Date: Mon, 3 Nov 2014 11:41:24 +0000 From: Stefan Hajnoczi Message-ID: <20141103114124.GA10995@stefanha-thinkpad.redhat.com> References: <1414076175-17034-1-git-send-email-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wRRV7LY7NUeQGEoC" Content-Disposition: inline In-Reply-To: <1414076175-17034-1-git-send-email-mreitz@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/2] block: JSON filenames and relative backing files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi --wRRV7LY7NUeQGEoC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 23, 2014 at 04:56:13PM +0200, Max Reitz wrote: > Sometimes, qemu does not have a filename to work with (it then generates > a JSON filename), so it does not know which directory to use for a > backing file specified by a relative filename. >=20 > In this case, qemu should not somehow try to append the backing file's > name to the JSON object, but rather just print an error and bail out. >=20 >=20 > Max Reitz (2): > block: JSON filenames and relative backing files > iotests: Add test for relative backing file names >=20 > block.c | 19 +++++++--- > block/qapi.c | 7 +++- > include/block/block.h | 2 +- > tests/qemu-iotests/110 | 87 ++++++++++++++++++++++++++++++++++++++++= ++++++ > tests/qemu-iotests/110.out | 15 ++++++++ > tests/qemu-iotests/group | 1 + > 6 files changed, 125 insertions(+), 6 deletions(-) > create mode 100755 tests/qemu-iotests/110 > create mode 100644 tests/qemu-iotests/110.out Unfortunately this breaks qemu-iotests check -vmdk 110 so I had to drop the patches. 110 0s ... - output mismatch (see 110.out.bad) --- /home/stefanha/qemu/tests/qemu-iotests/110.out 2014-11-03 09:48:42.1579= 55288 +0000 +++ 110.out.bad 2014-11-03 10:11:59.469231898 +0000 @@ -3,13 +3,26 @@ =3D=3D=3D Reconstructable filename =3D=3D=3D =20 Formatting 'TEST_DIR/t.IMGFMT.base', fmt=3DIMGFMT size=3D67108864=20 +qemu-img: TEST_DIR/t.IMGFMT: Could not open 't.IMGFMT.base': No such file = or directory Formatting 'TEST_DIR/t.IMGFMT', fmt=3DIMGFMT size=3D67108864 backing_file= =3D't.IMGFMT.base'=20 -image: TEST_DIR/t.IMGFMT -file format: IMGFMT -virtual size: 64M (67108864 bytes) -backing file: t.IMGFMT.base (actual path: TEST_DIR/t.IMGFMT.base) +qemu-img: Could not open 'json:{'driver':'IMGFMT','file':{'driver':'file',= 'filename':'TEST_DIR/t.IMGFMT'}}': Could not open 'TEST_DIR/t.IMGFMT': No s= uch file or directory =20 =3D=3D=3D Non-reconstructable filename =3D=3D=3D =20 -qemu-img: Cannot use relative backing file names for 'json:{"driver": "IMG= FMT", "file": {"set-state": [{"new_state": 42, "state": 0, "event": "read_a= io"}], "image": {"driver": "file", "filename": "TEST_DIR/t.IMGFMT"}, "drive= r": "blkdebug"}}' +qemu-img: Could not open 'json:{ + 'driver': 'IMGFMT', + 'file': { + 'driver': 'blkdebug', + 'image': { + 'driver': 'file', + 'filename': 'TEST_DIR/t.IMGFMT' + }, + 'set-state': [ + { + 'event': 'read_aio', + 'new_state': 42 + } + ] + } +}': Could not open 'TEST_DIR/t.IMGFMT': No such file or directory --wRRV7LY7NUeQGEoC Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUV2nkAAoJEJykq7OBq3PIqicIAIzSxSbgPcV8Sw88OLC0a1Rd n7fsekpk0bvtu9CtuUIKGViI65NsIKyPSaSSGdlggjZVfUXyEuxs3fHrBaMlPXPh TRdlc8MPAYHp7ICicamHqT573qztDBfA0UpzHAN55+/3Qtogs3Q49r/gh9L7c+fY +0+rbxGwEnFHKTSQg9eO0YskKSnYwCM3jBwVROLJHXocPsGTGs6bANq+5Zo8GT56 BHt2FJDFJJfv1Lfhl3RJrpLEUqv6ntdNP1rG57WUIrYny95o0+4dUuV0GXyjukfF JcpgWYaRuG6ASAjj5e6nhFzg2YAQ44EgqQrvuFUXCDUC1aBqkxlegXyvIp3SgcE= =CymR -----END PGP SIGNATURE----- --wRRV7LY7NUeQGEoC--