From: Amit Shah <amit.shah@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] virtio-serial: avoid crash when port has no name
Date: Mon, 3 Nov 2014 17:53:21 +0530 [thread overview]
Message-ID: <20141103122321.GD27782@grmbl.mre> (raw)
In-Reply-To: <1414600347-23221-1-git-send-email-marcandre.lureau@gmail.com>
On (Wed) 29 Oct 2014 [17:32:27], Marc-André Lureau wrote:
> It seems "name" is not mandatory, and the following command line (based
> on one generated by current libvirt) will crash qemu at start:
>
> qemu-system-x86_64 \
> -device virtio-serial-pci \
> -device virtserialport,name=foo \
> -device virtconsole
>
> Program received signal SIGSEGV, Segmentation fault.
> __strcmp_ssse3 () at ../sysdeps/x86_64/strcmp.S:210
> 210 movlpd (%rsi), %xmm2
> Missing separate debuginfos, use: debuginfo-install
> python-libs-2.7.5-13.fc20.x86_64
> (gdb) bt
> #0 __strcmp_ssse3 () at ../sysdeps/x86_64/strcmp.S:210
> #1 0x000055555566bdc6 in find_port_by_name (name=0x0) at /home/elmarco/src/qemu/hw/char/virtio-serial-bus.c:67
Missing signed-off-by. Can't queue this patch without that.
Amit
prev parent reply other threads:[~2014-11-03 12:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-29 16:32 [Qemu-devel] [PATCH] virtio-serial: avoid crash when port has no name Marc-André Lureau
2014-10-30 5:36 ` Amit Shah
2014-11-03 12:23 ` Amit Shah [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141103122321.GD27782@grmbl.mre \
--to=amit.shah@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).