From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45389) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlGfb-0007hN-Kj for qemu-devel@nongnu.org; Mon, 03 Nov 2014 07:23:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XlGfV-0001oK-GT for qemu-devel@nongnu.org; Mon, 03 Nov 2014 07:23:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52934) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlGfV-0001oE-8v for qemu-devel@nongnu.org; Mon, 03 Nov 2014 07:23:33 -0500 Date: Mon, 3 Nov 2014 17:53:21 +0530 From: Amit Shah Message-ID: <20141103122321.GD27782@grmbl.mre> References: <1414600347-23221-1-git-send-email-marcandre.lureau@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1414600347-23221-1-git-send-email-marcandre.lureau@gmail.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] virtio-serial: avoid crash when port has no name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?Marc-Andr=E9?= Lureau Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org On (Wed) 29 Oct 2014 [17:32:27], Marc-Andr=E9 Lureau wrote: > It seems "name" is not mandatory, and the following command line (based > on one generated by current libvirt) will crash qemu at start: >=20 > qemu-system-x86_64 \ > -device virtio-serial-pci \ > -device virtserialport,name=3Dfoo \ > -device virtconsole >=20 > Program received signal SIGSEGV, Segmentation fault. > __strcmp_ssse3 () at ../sysdeps/x86_64/strcmp.S:210 > 210 movlpd (%rsi), %xmm2 > Missing separate debuginfos, use: debuginfo-install > python-libs-2.7.5-13.fc20.x86_64 > (gdb) bt > #0 __strcmp_ssse3 () at ../sysdeps/x86_64/strcmp.S:210 > #1 0x000055555566bdc6 in find_port_by_name (name=3D0x0) at /home/elma= rco/src/qemu/hw/char/virtio-serial-bus.c:67 Missing signed-off-by. Can't queue this patch without that. Amit