From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48200) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlGqK-0000Mm-Es for qemu-devel@nongnu.org; Mon, 03 Nov 2014 07:34:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XlGqF-0004u6-U9 for qemu-devel@nongnu.org; Mon, 03 Nov 2014 07:34:44 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56878) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlGqF-0004tw-MC for qemu-devel@nongnu.org; Mon, 03 Nov 2014 07:34:39 -0500 Date: Mon, 3 Nov 2014 14:34:32 +0200 From: "Michael S. Tsirkin" Message-ID: <20141103123432.GA14587@redhat.com> References: <1414033363-31032-1-git-send-email-chao.p.peng@linux.intel.com> <20141102101909.GA31841@redhat.com> <5457679E.4030308@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5457679E.4030308@redhat.com> Subject: Re: [Qemu-devel] [PATCH] target-i386: add Intel AVX-512 support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kvm@vger.kernel.org, Marcelo Tosatti , qemu-devel@nongnu.org, Vadim Rozenfeld , Chao Peng , Laszlo Ersek , Andreas =?iso-8859-1?Q?F=E4rber?= On Mon, Nov 03, 2014 at 12:31:42PM +0100, Paolo Bonzini wrote: > > On 02/11/2014 11:19, Michael S. Tsirkin wrote: > > > Add AVX512 feature bits, register definition and corresponding > > > xsave/vmstate support. > > > > > > Signed-off-by: Chao Peng > > > > Thanks! > > > > As this was first posted after soft freeze, please > > resubmit after 2.2 is out. > > > > See schedule http://wiki.qemu.org/Planning/2.2 > > Actually this is already in. > > While "Planning/2.2" says "all features should have patches posted on > the mailing list", the actual page describing soft feature freeze is > more lenient: > > By the date of the soft feature freeze, any non-trivial feature > should have some code posted to the qemu-devel mailing list if it's > targeting a given release. Major features, and in particular > features with a high likelihood of breaking things, should already > be in the process of being merged. > > This patch was fairly trivial, as it only adds a few memcpys and a > subsection. Likelihood of breaking things is basically zero because > AVX512 does not yet exist in silicon. Eduardo reviewed the patch > promptly and agreed with putting it in 2.2, so that's what I did. > > Paolo Oh that's fine. I was not trying to argue, I didn't notice it was in and thought I'm asked to merge it. It's always a judgement call, I trust you did the right thing. Thanks and sorry about the noise. -- MST