qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] ui/gtk.c vs old gtk versions
Date: Mon, 3 Nov 2014 14:11:35 +0100	[thread overview]
Message-ID: <20141103131135.GA22901@noname.str.redhat.com> (raw)
In-Reply-To: <20141103140649.2826515c.cornelia.huck@de.ibm.com>

Am 03.11.2014 um 14:06 hat Cornelia Huck geschrieben:
> After the latest gtk updates, master fails to build for me on a
> SLES11SP3 machine:
> 
> /home/cohuck/git/qemu/ui/gtk.c: In function ‘gd_key_event’:
> /home/cohuck/git/qemu/ui/gtk.c:943: error: ‘GDK_KEY_Pause’ undeclared (first use in this function)
> /home/cohuck/git/qemu/ui/gtk.c:943: error: (Each undeclared identifier is reported only once
> /home/cohuck/git/qemu/ui/gtk.c:943: error: for each function it appears in.)
> 
> Of course, the gtk version is not the freshest:
> 
> pkg-config --modversion "gtk+-2.0"
> 2.18.9
> 
> On machines with less-ancient gtk (say 2.24) everything builds fine.
> 
> I don't really care about gtk support on the SLES11 machine (it's s390
> anyway), but we should probably either fence the pause key support or
> have configure require a more recent version.

I think I saw the same thing on RHEL 6 (and hacked around it because I
didn't have time to investigate it).

Kevin

  reply	other threads:[~2014-11-03 13:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-03 13:06 [Qemu-devel] ui/gtk.c vs old gtk versions Cornelia Huck
2014-11-03 13:11 ` Kevin Wolf [this message]
2014-11-03 13:32   ` Daniel P. Berrange
2014-11-03 22:27     ` Cole Robinson
2014-11-04  8:40       ` Cornelia Huck
2014-11-04  8:51       ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141103131135.GA22901@noname.str.redhat.com \
    --to=kwolf@redhat.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).