From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58649)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1XlHQA-0008R5-Jo
	for qemu-devel@nongnu.org; Mon, 03 Nov 2014 08:11:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1XlHQ4-00014p-Fm
	for qemu-devel@nongnu.org; Mon, 03 Nov 2014 08:11:46 -0500
Received: from mx1.redhat.com ([209.132.183.28]:45129)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1XlHQ4-00014k-9R
	for qemu-devel@nongnu.org; Mon, 03 Nov 2014 08:11:40 -0500
Date: Mon, 3 Nov 2014 14:11:35 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20141103131135.GA22901@noname.str.redhat.com>
References: <20141103140649.2826515c.cornelia.huck@de.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20141103140649.2826515c.cornelia.huck@de.ibm.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] ui/gtk.c vs old gtk versions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>

Am 03.11.2014 um 14:06 hat Cornelia Huck geschrieben:
> After the latest gtk updates, master fails to build for me on a
> SLES11SP3 machine:
>=20
> /home/cohuck/git/qemu/ui/gtk.c: In function =E2=80=98gd_key_event=E2=80=
=99:
> /home/cohuck/git/qemu/ui/gtk.c:943: error: =E2=80=98GDK_KEY_Pause=E2=80=
=99 undeclared (first use in this function)
> /home/cohuck/git/qemu/ui/gtk.c:943: error: (Each undeclared identifier =
is reported only once
> /home/cohuck/git/qemu/ui/gtk.c:943: error: for each function it appears=
 in.)
>=20
> Of course, the gtk version is not the freshest:
>=20
> pkg-config --modversion "gtk+-2.0"
> 2.18.9
>=20
> On machines with less-ancient gtk (say 2.24) everything builds fine.
>=20
> I don't really care about gtk support on the SLES11 machine (it's s390
> anyway), but we should probably either fence the pause key support or
> have configure require a more recent version.

I think I saw the same thing on RHEL 6 (and hacked around it because I
didn't have time to investigate it).

Kevin