From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36226)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1XlHkA-00042z-12
	for qemu-devel@nongnu.org; Mon, 03 Nov 2014 08:32:29 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1XlHk6-0008UD-5a
	for qemu-devel@nongnu.org; Mon, 03 Nov 2014 08:32:25 -0500
Received: from mx1.redhat.com ([209.132.183.28]:47524)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1XlHk5-0008U9-Uj
	for qemu-devel@nongnu.org; Mon, 03 Nov 2014 08:32:22 -0500
Date: Mon, 3 Nov 2014 14:32:14 +0100
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20141103133214.GB31724@redhat.com>
References: <20141103140649.2826515c.cornelia.huck@de.ibm.com>
	<20141103131135.GA22901@noname.str.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20141103131135.GA22901@noname.str.redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] ui/gtk.c vs old gtk versions
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>, qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>

On Mon, Nov 03, 2014 at 02:11:35PM +0100, Kevin Wolf wrote:
> Am 03.11.2014 um 14:06 hat Cornelia Huck geschrieben:
> > After the latest gtk updates, master fails to build for me on a
> > SLES11SP3 machine:
> >=20
> > /home/cohuck/git/qemu/ui/gtk.c: In function =E2=80=98gd_key_event=E2=80=
=99:
> > /home/cohuck/git/qemu/ui/gtk.c:943: error: =E2=80=98GDK_KEY_Pause=E2=80=
=99 undeclared (first use in this function)
> > /home/cohuck/git/qemu/ui/gtk.c:943: error: (Each undeclared identifie=
r is reported only once
> > /home/cohuck/git/qemu/ui/gtk.c:943: error: for each function it appea=
rs in.)
> >=20
> > Of course, the gtk version is not the freshest:
> >=20
> > pkg-config --modversion "gtk+-2.0"
> > 2.18.9
> >=20
> > On machines with less-ancient gtk (say 2.24) everything builds fine.
> >=20
> > I don't really care about gtk support on the SLES11 machine (it's s39=
0
> > anyway), but we should probably either fence the pause key support or
> > have configure require a more recent version.
>=20
> I think I saw the same thing on RHEL 6 (and hacked around it because I
> didn't have time to investigate it).

In older versions of GDK, the constants were lacking the 'KEY_' part,
so it would have just been  GDK_Pause.

In GTK-VNC I worked around this by adding this kind of thing to our
source

  #ifndef GDK_Return
  #define GDK_Return GDK_KEY_Return
  #endif

Since there was a fairly small set of key constants that we needed to
care about.

Regards,
Daniel
--=20
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange=
/ :|
|: http://libvirt.org              -o-             http://virt-manager.or=
g :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr=
/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vn=
c :|