From: "Michael S. Tsirkin" <mst@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] qemu-char: fix tcp_get_fds
Date: Mon, 3 Nov 2014 18:32:14 +0200 [thread overview]
Message-ID: <20141103163214.GF24877@redhat.com> (raw)
In-Reply-To: <CAFEAcA9XO4A9qC8QK=hB1Nw5nUUT=Oh+P6ZvNUw2z2FxWHhVUg@mail.gmail.com>
On Mon, Nov 03, 2014 at 04:22:57PM +0000, Peter Maydell wrote:
> On 3 November 2014 16:13, Markus Armbruster <armbru@redhat.com> wrote:
> > "Michael S. Tsirkin" <mst@redhat.com> writes:
> >
> >> On Mon, Nov 03, 2014 at 04:09:36PM +0100, Markus Armbruster wrote:
> >>> "Michael S. Tsirkin" <mst@redhat.com> writes:
> >>>
> >>> > tcp_get_fds API discards fds if there's more than 1 of these.
> >>>
> >>> s/tcp_get_fds/tcp_get_msgfds/ (subject as well)
> >>
> >> Right. Too late as I sent this upstream :(
> >
> > Oh, now I see: you already sent this in a pull request, after less than
> > 20 hours on list. Please don't do that except in dire emergency. It
> > sabotages our review process.
>
> ...I haven't actually applied that yet, though. Since this
> isn't a critical bugfix I think it would probably be reasonable
> to respin the pull without this patch, so it has a bit more
> chance for review. Since it's not a new feature there's no
> need to rush to get it in before hardfreeze, right?
>
> -- PMM
Okay.
next prev parent reply other threads:[~2014-11-03 16:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-02 16:53 [Qemu-devel] [PATCH] qemu-char: fix tcp_get_fds Michael S. Tsirkin
2014-11-03 15:09 ` Markus Armbruster
2014-11-03 15:19 ` Michael S. Tsirkin
2014-11-03 16:06 ` Markus Armbruster
2014-11-03 16:13 ` Markus Armbruster
2014-11-03 16:22 ` Peter Maydell
2014-11-03 16:32 ` Michael S. Tsirkin [this message]
2014-11-03 16:35 ` Michael S. Tsirkin
2014-11-04 0:17 ` Peter Maydell
2014-11-04 13:49 ` Michael S. Tsirkin
2014-11-03 16:40 ` Michael S. Tsirkin
2014-11-04 6:50 ` Markus Armbruster
2014-11-27 9:58 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141103163214.GF24877@redhat.com \
--to=mst@redhat.com \
--cc=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).