From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50279) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlT5t-0008O8-Tl for qemu-devel@nongnu.org; Mon, 03 Nov 2014 20:39:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XlT5n-0006Fs-Qr for qemu-devel@nongnu.org; Mon, 03 Nov 2014 20:39:37 -0500 Received: from ozlabs.org ([2401:3900:2:1::2]:54763) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlT5n-0006FA-G1 for qemu-devel@nongnu.org; Mon, 03 Nov 2014 20:39:31 -0500 Date: Tue, 4 Nov 2014 12:28:15 +1100 From: David Gibson Message-ID: <20141104012815.GC27321@voom.fritz.box> References: <1412358473-31398-1-git-send-email-dgilbert@redhat.com> <1412358473-31398-23-git-send-email-dgilbert@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="5G06lTa6Jq83wMTw" Content-Disposition: inline In-Reply-To: <1412358473-31398-23-git-send-email-dgilbert@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 22/47] QEMU_VM_CMD_PACKAGED: Send a packaged chunk of migration stream List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, lilei@linux.vnet.ibm.com, quintela@redhat.com, cristian.klein@cs.umu.se, qemu-devel@nongnu.org, amit.shah@redhat.com, yanghy@cn.fujitsu.com --5G06lTa6Jq83wMTw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 03, 2014 at 06:47:28PM +0100, Dr. David Alan Gilbert (git) wrot= e: > From: "Dr. David Alan Gilbert" >=20 > QEMU_VM_CMD_PACKAGED is a migration command that allows a chunk > of migration stream to be sent in one go, and be received by > a separate instance of the loadvm loop while not interacting > with the migration stream. >=20 > This is used by postcopy to load device state (from the package) > while loading memory pages from the main stream. >=20 > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: David Gibson Though one minor comment: [snip] > +/* We have a buffer of data to send; we don't want that all to be loaded > + * by the command itself, so the command contains just the length of the > + * extra buffer that we then send straight after it. > + * TODO: Must be a better way to organise that I'm not quite understanding what that comment's getting at. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --5G06lTa6Jq83wMTw Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUWCuvAAoJEGw4ysog2bOSy6QQALl97PUOX1gte+6b5MkpeyUA tdFFjx5Ggi4Agqtwdb0wIedjCtrSCc40RYEUGRx5spfej9nFBPM+20O/ByIsFFcA WXxIWGVuaXBalazlXyH2VFfrXs4041Ub1d21d9r2n9VP9h0ulN2vyo1IV8++L1dR g6X+Sr34ceB0PZNwPCubEjL1gqHc0OVaGQid4eCDp9oK3NjxqsypR8Frlru/pVWB VMD86MC8G+4JSLUng2XaoII1hNBCUjEdaMAsa6LAU/gDpBKBOlIwpWWQadx/A8Mi f36KdZhiFLzv2aW8T0s0Ig434aSGU78R5Xi6SsdOm8h7EHOCnmK5fU5tch7fDhLP JS0B8Ib0zTYdv1rJPkVWOXNPM93O/Y9i75hjC2cvCnXaHKcy5jcSGFczyzfHUWW3 GiX91rommaGmhATQ8wQwecR34THuk65YoKrK9xavWtPYC8fT8H2VOb7M/i+lIsJ7 H3rtkJgSdhEENro0t4BYwrhwFnRbJ9+knM8awNWtue2xp2pKUX8hVrgDKJsFvcLY F9hNuP05JGb02tdcA8lxF/SAzey2mapCte3BmpCTDnlAtxWEh8iUHUiYSNuQXtoT LxBEppDoR6wJjzYtYCN8c8FwIrnpBM0Kt+lxvbn2EMkF9OnWYJcwUT2d3QOCkvup /cQ+kclfeHwbmCPbV1W3 =hOfV -----END PGP SIGNATURE----- --5G06lTa6Jq83wMTw--