From: Stefan Hajnoczi <stefanha@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: jcody@redhat.com, mreitz@redhat.com, qemu-devel@nongnu.org,
armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2/4] block: Read only one sector for format probing
Date: Tue, 4 Nov 2014 15:32:52 +0000 [thread overview]
Message-ID: <20141104153252.GB28330@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1414671976-5353-3-git-send-email-kwolf@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 715 bytes --]
On Thu, Oct 30, 2014 at 01:26:14PM +0100, Kevin Wolf wrote:
> The only image format driver that even potentially accesses anything
> after 512 bytes in its bdrv_probe() implementation is VMDK, which reads
> a plain-text descriptor file. In practice, the field it's looking for
> seems to come first and will be well within the first 512 bytes, too.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block.c | 2 +-
> include/block/block_int.h | 2 ++
> 2 files changed, 3 insertions(+), 1 deletion(-)
I tried to find a logical reason for the historical 1024 and 2048 byte
sizes but it's not clear. 512 should be fine.
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-11-04 15:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-30 12:26 [Qemu-devel] [PATCH 0/4] raw: Prohibit dangerous writes for probed images Kevin Wolf
2014-10-30 12:26 ` [Qemu-devel] [PATCH 1/4] block: Factor bdrv_probe_all() out of find_image_format() Kevin Wolf
2014-10-30 12:26 ` [Qemu-devel] [PATCH 2/4] block: Read only one sector for format probing Kevin Wolf
2014-11-04 15:32 ` Stefan Hajnoczi [this message]
2014-10-30 12:26 ` [Qemu-devel] [PATCH 3/4] raw: Prohibit dangerous writes for probed images Kevin Wolf
2014-10-30 12:43 ` Kevin Wolf
2014-10-30 14:27 ` Eric Blake
2014-10-31 9:34 ` Kevin Wolf
2014-11-04 15:41 ` Stefan Hajnoczi
2014-10-30 12:26 ` [Qemu-devel] [PATCH 4/4] qemu-iotests: Test writing non-raw image headers to raw image Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141104153252.GB28330@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=armbru@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).