From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32904) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlqGg-0002nw-7C for qemu-devel@nongnu.org; Tue, 04 Nov 2014 21:24:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XlqGb-0007sM-Og for qemu-devel@nongnu.org; Tue, 04 Nov 2014 21:24:18 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35067) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlqGb-0007rL-IO for qemu-devel@nongnu.org; Tue, 04 Nov 2014 21:24:13 -0500 Date: Tue, 4 Nov 2014 21:24:09 -0500 From: Jeff Cody Message-ID: <20141105022409.GJ26767@localhost.localdomain> References: <1414589891-32736-1-git-send-email-den@openvz.org> <1414589891-32736-4-git-send-email-den@openvz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1414589891-32736-4-git-send-email-den@openvz.org> Subject: Re: [Qemu-devel] [PATCH 3/6] iotests: simple parallels XML disk descriptor file test added List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi On Wed, Oct 29, 2014 at 04:38:08PM +0300, Denis V. Lunev wrote: > Signed-off-by: Denis V. Lunev > Acked-by: Roman Kagan > CC: Jeff Cody > CC: Kevin Wolf > CC: Stefan Hajnoczi > --- > tests/qemu-iotests/076 | 6 ++++++ > tests/qemu-iotests/076.out | 4 ++++ > tests/qemu-iotests/sample_images/parallels-simple.xml.bz2 | Bin 0 -> 374 bytes > 3 files changed, 10 insertions(+) > create mode 100644 tests/qemu-iotests/sample_images/parallels-simple.xml.bz2 > > diff --git a/tests/qemu-iotests/076 b/tests/qemu-iotests/076 > index ed2be35..242d0c3 100755 > --- a/tests/qemu-iotests/076 > +++ b/tests/qemu-iotests/076 > @@ -75,6 +75,12 @@ echo "== Read from a valid v2 image ==" > _use_sample_img parallels-v2.bz2 > { $QEMU_IO -c "read -P 0x11 0 64k" $TEST_IMG; } 2>&1 | _filter_qemu_io | _filter_testdir > > +echo > +echo "== Read from a valid v2 image opened through xml ==" > +_use_sample_img parallels-v2.bz2 > +_use_sample_img parallels-simple.xml.bz2 > +{ $QEMU_IO -c "read -P 0x11 0 64k" $TEST_IMG; } 2>&1 | _filter_qemu_io | _filter_testdir > + $TEST_IMG should be quoted, to be path-safe ("$TEST_IMG") - although, looks like 076 has some other instances of unquoted $TEST_IMG, as well (not your fault). I don't care if you fix it here or not, we can fix them all up in a later patch. > # success, all done > echo "*** done" > rm -f $seq.full > diff --git a/tests/qemu-iotests/076.out b/tests/qemu-iotests/076.out > index 32ade08..628d9bf 100644 > --- a/tests/qemu-iotests/076.out > +++ b/tests/qemu-iotests/076.out > @@ -19,4 +19,8 @@ no file open, try 'help open' > == Read from a valid v2 image == > read 65536/65536 bytes at offset 0 > 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > + > +== Read from a valid v2 image opened through xml == > +read 65536/65536 bytes at offset 0 > +64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > *** done > diff --git a/tests/qemu-iotests/sample_images/parallels-simple.xml.bz2 b/tests/qemu-iotests/sample_images/parallels-simple.xml.bz2 > new file mode 100644 > index 0000000000000000000000000000000000000000..13760bc9f30246ba01f43cdca3d3d90780430f61 > GIT binary patch > literal 374 > zcmV-+0g3)XT4*^jL0KkKSx`RPoB#ls-+)w5Py_$xpWsdazwh08Faddp1^@s613&-( > z00UFVg-_KD8fY4NVup`X5ukcZBTOVwCXAT_OhRY?0}wJ9sXCPa+IAr*0!sLV#k$+r > zFRIp6TJ>A%(u7Qkn2MJtX_(TWtce9REA{g&qLoa&l#2??q)aKM7Qx|d6glC9JSZw~ > z-{Dy+9yLxWKg_2Xm02klNIFQqySl|-EJ?WkLWzOBm`Xui7_);kgut`D zCYzWh49n~Qks#g*ByEgsjlH07DHv)~9ZRui7r}`9{%wsd23x|ItiZh!U&QMH5t zN>^IdcIOOiAVM)WoC{=C8L4k%Ybsug63k@+f`frkh@_Ij10W;xr->@K!oLkGw3Lv$ > zS&-sh3*_e*@-+(JnDfSD#7GS;nh3VYlxtRDgM UX+T&T%b)nWk}1N3f`Rtj;5{a#bN~PV > > literal 0 > HcmV?d00001 > > -- > 1.9.1 > Reviewed-by: Jeff Cody