[Qemu-devel] [PATCHv2] virtio-serial: avoid crash when port has no name

[Qemu-devel] [PATCHv2] virtio-serial: avoid crash when port has no name

[Marc-André Lureau]

It seems "name" is not mandatory, and the following command line (based
on one generated by current libvirt) will crash qemu at start:

qemu-system-x86_64 \
    -device virtio-serial-pci \
    -device virtserialport,name=foo \
    -device virtconsole

Program received signal SIGSEGV, Segmentation fault.
__strcmp_ssse3 () at ../sysdeps/x86_64/strcmp.S:210
210        movlpd    (%rsi), %xmm2
Missing separate debuginfos, use: debuginfo-install
python-libs-2.7.5-13.fc20.x86_64
(gdb) bt
 #0  __strcmp_ssse3 () at ../sysdeps/x86_64/strcmp.S:210
 #1  0x000055555566bdc6 in find_port_by_name (name=0x0) at /home/elmarco/src/qemu/hw/char/virtio-serial-bus.c:67

Signed-off-by: Marc-André Lureau <marcandre.lureau@gmail.com>
---
 hw/char/virtio-serial-bus.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c
index 3931085..f16452e 100644
--- a/hw/char/virtio-serial-bus.c
+++ b/hw/char/virtio-serial-bus.c
@@ -871,7 +871,7 @@ static void virtser_port_device_realize(DeviceState *dev, Error **errp)
         return;
     }
 
-    if (find_port_by_name(port->name)) {
+    if (port->name != NULL && find_port_by_name(port->name)) {
         error_setg(errp, "virtio-serial-bus: A port already exists by name %s",
                    port->name);
         return;
-- 
1.9.3

Re: [Qemu-devel] [PATCHv2] virtio-serial: avoid crash when port has no name

[Amos Kong]

[-- Attachment #1: Type: text/plain, Size: 1586 bytes --]

On Wed, Nov 05, 2014 at 03:43:14PM +0100, Marc-André Lureau wrote:
> It seems "name" is not mandatory, and the following command line (based
> on one generated by current libvirt) will crash qemu at start:
> 
> qemu-system-x86_64 \
>     -device virtio-serial-pci \
>     -device virtserialport,name=foo \
>     -device virtconsole
> 
> Program received signal SIGSEGV, Segmentation fault.
> __strcmp_ssse3 () at ../sysdeps/x86_64/strcmp.S:210
> 210        movlpd    (%rsi), %xmm2
> Missing separate debuginfos, use: debuginfo-install
> python-libs-2.7.5-13.fc20.x86_64
> (gdb) bt
>  #0  __strcmp_ssse3 () at ../sysdeps/x86_64/strcmp.S:210
>  #1  0x000055555566bdc6 in find_port_by_name (name=0x0) at /home/elmarco/src/qemu/hw/char/virtio-serial-bus.c:67
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@gmail.com>
> ---
>  hw/char/virtio-serial-bus.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c
> index 3931085..f16452e 100644
> --- a/hw/char/virtio-serial-bus.c
> +++ b/hw/char/virtio-serial-bus.c
> @@ -871,7 +871,7 @@ static void virtser_port_device_realize(DeviceState *dev, Error **errp)
>          return;
>      }
>  
> -    if (find_port_by_name(port->name)) {
> +    if (port->name != NULL && find_port_by_name(port->name)) {
>          error_setg(errp, "virtio-serial-bus: A port already exists by name %s",
>                     port->name);
>          return;
> -- 
> 1.9.3
> 

Reviewed-by: Amos Kong <akong@redhat.com>

-- 
			Amos.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]