Re: [Qemu-devel] [PATCH] ui/input: strictly check console in finding input handler

[Amos Kong <akong@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1282 bytes --]

On Wed, Nov 05, 2014 at 09:47:47AM +0100, Gerd Hoffmann wrote:
> On Mi, 2014-11-05 at 00:49 +0800, Amos Kong wrote:
> > qemu_input_find_handler() prefers a handler associated with con.
> > But if none exists, it takes any. This patch added a parameter
> > to strictly check console, in case we want to input event to
> > special console.

If console is assigned, it will try to find right handler by first
loop in qemu_input_find_handler(). The second loop is used to find
mask matched handler if console isn't assigned.

If we assigned console and didn't find handler in first loop, it
skip second loop body by 'continue', and return NULL.
It seems my concern is wrong, we don't need this repeated parameter.

NACK this patch.

Thanks.
 
> > 'input-send-event' has a parameter to assign special console,
> > so we should enable strict checking in finding handler.
> 
> I don't think we want do that by default.  It only matters in case of a
> multiseat setup where you actually have multiple input devices of the
> same kind.  Which isn't a very typical use case.
> 
> Options I see are:
> 
>   (a) Turn console into an optional parameter, do strict checking in
>       case it is present.
>   (b) Add a optional 'strict' parameter.

-- 
			Amos.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]