From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49887) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xmgpo-0001KL-2k for qemu-devel@nongnu.org; Fri, 07 Nov 2014 05:32:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xmgpi-0008PP-1r for qemu-devel@nongnu.org; Fri, 07 Nov 2014 05:32:04 -0500 Received: from mail.ispras.ru ([83.149.199.45]:49107) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xmgph-0008PH-RI for qemu-devel@nongnu.org; Fri, 07 Nov 2014 05:31:58 -0500 From: Pavel Dovgalyuk Date: Fri, 07 Nov 2014 13:32:01 +0300 Message-ID: <20141107103201.6136.89187.stgit@PASHA-ISP> In-Reply-To: <20141107103123.6136.18545.stgit@PASHA-ISP> References: <20141107103123.6136.18545.stgit@PASHA-ISP> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [RFC PATCH v4 06/25] cpu-exec: reset exception_index correctly List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, alex.bennee@linaro.org, mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru, maria.klimushenkova@ispras.ru, pavel.dovgaluk@ispras.ru, pbonzini@redhat.com, afaerber@suse.de, fred.konrad@greensocs.com Exception index is reset at every entry at every entry into cpu_exec() function. This may cause missing the exceptions while replaying them. This patch moves exception_index reset to the locations where they are processed. Signed-off-by: Pavel Dovgalyuk --- cpu-exec.c | 2 +- cpus.c | 1 + 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/cpu-exec.c b/cpu-exec.c index 8830255..011f51f 100644 --- a/cpu-exec.c +++ b/cpu-exec.c @@ -358,7 +358,6 @@ int cpu_exec(CPUArchState *env) } cc->cpu_exec_enter(cpu); - cpu->exception_index = -1; /* Calculate difference between guest clock and host clock. * This delay includes the delay of the last cycle, so @@ -378,6 +377,7 @@ int cpu_exec(CPUArchState *env) if (ret == EXCP_DEBUG) { cpu_handle_debug_exception(env); } + cpu->exception_index = -1; break; } else { #if defined(CONFIG_USER_ONLY) diff --git a/cpus.c b/cpus.c index e53d605..7e8c507 100644 --- a/cpus.c +++ b/cpus.c @@ -1016,6 +1016,7 @@ static void *qemu_tcg_cpu_thread_fn(void *arg) CPU_FOREACH(cpu) { cpu->thread_id = qemu_get_thread_id(); cpu->created = true; + cpu->exception_index = -1; } qemu_cond_signal(&qemu_cpu_cond);