From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45695) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XnkT9-0004Wz-Ha for qemu-devel@nongnu.org; Mon, 10 Nov 2014 03:37:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XnkT0-0006VU-HM for qemu-devel@nongnu.org; Mon, 10 Nov 2014 03:37:03 -0500 Received: from mail-pa0-x22b.google.com ([2607:f8b0:400e:c03::22b]:61458) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XnkT0-0006VO-Aw for qemu-devel@nongnu.org; Mon, 10 Nov 2014 03:36:54 -0500 Received: by mail-pa0-f43.google.com with SMTP id eu11so7815431pac.30 for ; Mon, 10 Nov 2014 00:36:53 -0800 (PST) Date: Mon, 10 Nov 2014 16:36:48 +0800 From: Jun Li Message-ID: <20141110083647.GA28508@localhost.localdomain> References: <1414336849-21179-1-git-send-email-junmuzi@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1414336849-21179-1-git-send-email-junmuzi@gmail.com> Subject: Re: [Qemu-devel] [PATCH v5 0/3] qcow2: Patch for shrinking qcow2 disk image List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, juli@redhat.com, famz@redhat.com, stefanha@redhat.com Ping Stefan and Kevin, Could anyone help to review this version of patch ? Thx. Regards, Jun Li On Sun, 10/26 23:20, Jun Li wrote: > v5: > Add qemu-iotests for qcow2 shrinking. Do some modifications based on MAX's suggestions in v4. > > v4: > Add deal with COW clusters in l2 table. When using COW, some of (l2_entry >> > s->cluster_bits) will larger than s->refcount_table_size, so need to discard > this l2_entry. > > v3: > Fixed host cluster leak. > > > In file block/qcow2.c, just using ftruncate to fix host cluster leak. > > In file block/qcow2-cluster.c, just re-copy qcow2_grow_l1_table to > realize qcow2_shrink_l1_and_l2_table. > > In file block/qcow2-refcount.c, also update the realization to handle self-describing > refcount blocks in function update_refcount. > > Thanks. > > > Jun Li (3): > qcow2: Add qcow2_shrink_l1_and_l2_table for qcow2 shrinking > qcow2: add update refcount table realization for update_refcount > qcow2: Add qemu-iotests for qcow2 shrinking > > block/qcow2-cluster.c | 182 +++++++++++++++++++++++++++++++++++++++++++++ > block/qcow2-refcount.c | 49 +++++++++++- > block/qcow2.c | 37 ++++++++- > block/qcow2.h | 2 + > tests/qemu-iotests/110 | 76 +++++++++++++++++++ > tests/qemu-iotests/110.out | 13 ++++ > tests/qemu-iotests/group | 1 + > 7 files changed, 356 insertions(+), 4 deletions(-) > create mode 100755 tests/qemu-iotests/110 > create mode 100644 tests/qemu-iotests/110.out > > -- > 1.9.3 >