From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55781) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xo2Aq-0007Jd-Qg for qemu-devel@nongnu.org; Mon, 10 Nov 2014 22:31:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xo2Am-0006JA-QE for qemu-devel@nongnu.org; Mon, 10 Nov 2014 22:31:20 -0500 Date: Tue, 11 Nov 2014 14:19:23 +1100 From: David Gibson Message-ID: <20141111031923.GG15270@voom.redhat.com> References: <20141105071019.26196.93729.stgit@aravindap> <20141105071315.26196.68104.stgit@aravindap> <5459E0B4.3040402@suse.de> <545A464F.7080906@gmail.com> <545B46A1.6060009@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="TdkiTnkLhLQllcMS" Content-Disposition: inline In-Reply-To: <545B46A1.6060009@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 4/4] target-ppc: Handle ibm, nmi-register RTAS call List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aravinda Prasad Cc: Tom Musta , benh@au1.ibm.com, aik@au1.ibm.com, Alexander Graf , qemu-devel@nongnu.org, qemu-ppc@nongnu.org, paulus@samba.org --TdkiTnkLhLQllcMS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 06, 2014 at 03:30:01PM +0530, Aravinda Prasad wrote: > On Wednesday 05 November 2014 09:16 PM, Tom Musta wrote: > > On 11/5/2014 2:32 AM, Alexander Graf wrote: > >> On 05.11.14 08:13, Aravinda Prasad wrote: [snip] > >>> + /* > >>> + * ori r3,r3,KVMPPC_H_REPORT_MC_ERR. The KVMPPC_H_REPORT_MC_ERR > >>> + * value is patched below > >>> + */ > >>> +1: ori 3,3,0 > >=20 > > Why do "li 3,0" followed by "ori 3,3,X"? Isn't this just "li 3,X" ? (= aka "addi 3,0,X") >=20 > I remember I first tried doing li r3,X but faced some problem (but not > able to exactly recall what was the problem) may be due to not familiar > with ppc assembly. This would be because with the offset to the private hcalls, the actual hcall number is 0xf003, which means an li instruction will sign extend it incorrectly. So you will need two instructions to load the number. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --TdkiTnkLhLQllcMS Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUYYA7AAoJEGw4ysog2bOSIucP/279ug0jy9O9YfFjLXmYFuzn dgV0tr2wXdURlxkqAx5VqPZVwS9dnufZ6fVgHwBQUhdVgCURdvYLRaZViP1GdviF 221mI2YtmPTwlNxqdQO9k16J2iyEd5JEBf1EK6c2N20FxARr7YhHtdcpGYkNOxtN 4vzE9Em4RIrFri2zsXxYtDLbzTcRo0BRAeDckXMHx13FlZsEc1LucG6mPRENbUhb qgblc6YJgwZvIgxo8nudKd4pE7akON82IJ8d4jz1Z1PSZzc0GP+BLT5kL3Keo9re BzijyvAwy7vTLvgwgTqKclKD4yQybogJ9lRJChe18aNPPpuGJ3GMJRu724CBkenG JBd2frK6FP7JAhUyjXRt15pkKCWCRfc3qPzpNcYtVOuXUWxPEmYGgPq1jBMgbVhH V72zXtkCs0xnT1Gt6yO0hfOlqtrRXni1UBcwZKoOvieC8falrUs74lRXn1duVVUc edcQjhxmwSLo14a6Pzv3zdoPXmjD8x2zJaODJ7AyyUJUzRH2nGMz9brpIqh7/Mm+ yx5AKIG+rgAuoXKM5R2NeEZBaJXmFmulvTCv1M3flUduzhEoqplLjme5hG7HNmsW 8v1i36VdmiDwgJJAP7UKcv4Llcs40zTJ+aTqFvmkIW1eOSCiAOUW78YZ+ClIX9Jy FkIWr1Y8Fahk8W8q9TW3 =wAKU -----END PGP SIGNATURE----- --TdkiTnkLhLQllcMS--