From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49185) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xo4js-0003y9-Dn for qemu-devel@nongnu.org; Tue, 11 Nov 2014 01:15:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xo4jo-00070N-Ba for qemu-devel@nongnu.org; Tue, 11 Nov 2014 01:15:40 -0500 Date: Tue, 11 Nov 2014 17:11:24 +1100 From: David Gibson Message-ID: <20141111061124.GJ15270@voom.redhat.com> References: <20141105071019.26196.93729.stgit@aravindap> <20141105071315.26196.68104.stgit@aravindap> <5459E0B4.3040402@suse.de> <545A464F.7080906@gmail.com> <545B46A1.6060009@linux.vnet.ibm.com> <20141111031923.GG15270@voom.redhat.com> <5461A315.3040602@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="apbmkPN6Hu/1dI3g" Content-Disposition: inline In-Reply-To: <5461A315.3040602@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 4/4] target-ppc: Handle ibm, nmi-register RTAS call List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aravinda Prasad Cc: Tom Musta , benh@au1.ibm.com, aik@au1.ibm.com, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, paulus@samba.org --apbmkPN6Hu/1dI3g Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 11, 2014 at 11:18:05AM +0530, Aravinda Prasad wrote: >=20 >=20 > On Tuesday 11 November 2014 08:49 AM, David Gibson wrote: > > On Thu, Nov 06, 2014 at 03:30:01PM +0530, Aravinda Prasad wrote: > >> On Wednesday 05 November 2014 09:16 PM, Tom Musta wrote: > >>> On 11/5/2014 2:32 AM, Alexander Graf wrote: > >>>> On 05.11.14 08:13, Aravinda Prasad wrote: > >=20 > > [snip] > >>>>> + /* > >>>>> + * ori r3,r3,KVMPPC_H_REPORT_MC_ERR. The KVMPPC_H_REPORT_MC_ERR > >>>>> + * value is patched below > >>>>> + */ > >>>>> +1: ori 3,3,0 > >>> > >>> Why do "li 3,0" followed by "ori 3,3,X"? Isn't this just "li 3,X" ? = (aka "addi 3,0,X") > >> > >> I remember I first tried doing li r3,X but faced some problem (but not > >> able to exactly recall what was the problem) may be due to not familiar > >> with ppc assembly. > >=20 > > This would be because with the offset to the private hcalls, the > > actual hcall number is 0xf003, which means an li instruction will sign > > extend it incorrectly. So you will need two instructions to load the > > number. >=20 > hmm.. ok At least, I think you'll need to instructions. I don't remember for certain if 'ori 3,0,X' will OR X with literal 0 or the contents of r0. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --apbmkPN6Hu/1dI3g Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUYaiMAAoJEGw4ysog2bOSo40P+weIfK9RlZGEUk4xDipP3CZJ Sorh+RXdiU+mAMq+TczoXrUzJafD6SoN9B8qA6JTncqtmME2dKcaKeG9hrY4kaow EToGGYgm1Zj8axJ5sx/tbxB8rVJHyAiA7N4DXiDOzdEr5Vfu7d3j2J4lAAm9pEFH 5AL4td9CI7eK6QOWuH+gmrAgn/wstFHKKuivoMPocIqrLm2bYB4hgGQX/9aXMGe/ OYhcLETnQdZaNK91lg0pWLJUgwDP3Q9ZdYXQRDbHXPqTCsqT9HtStullPqoDdAa7 JjeepPBgc/rgs8obTaQJIS3R8c4mrYK0srKyKD6Q59lk8m+qZF2UWsv2sB7Rq4rC cFH4fQxhCSSrtAFPFYc7LTFhD0fxWOuBE8222EcliO6BAZGKxwPSEvL1of5jCbwf x8h5lTNjc8Icpmbt06WdqCR92obYuTfezccsyHdnz54yJBrc6NHv1OLaPSEV9yVD 06cP3tCdxDHsafyWQqdi4q3KYSi5j2N0X5l03veTRdhbulxJlIdbsXh0OdD619bY Or66hMeoZwecWNXiNa+HbVVyGkgDzqpvOjSmTVhqrXcbdLOEYp8yo0bVlZAsa+Ux R7BGm7N6UH+6IPsVLFQHePtOKRWRBWG13p07rtzTN3foI6BneamNM5vzPBGOKGer eCUsNcVaayLwdXKFwyMJ =/qMc -----END PGP SIGNATURE----- --apbmkPN6Hu/1dI3g--