From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39279) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XoF3b-0000VC-9J for qemu-devel@nongnu.org; Tue, 11 Nov 2014 12:16:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XoF3W-0003vc-FC for qemu-devel@nongnu.org; Tue, 11 Nov 2014 12:16:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33725) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XoF3W-0003vB-7U for qemu-devel@nongnu.org; Tue, 11 Nov 2014 12:16:38 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sABHGa9h022067 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 11 Nov 2014 12:16:36 -0500 Date: Tue, 11 Nov 2014 17:16:35 +0000 From: Stefan Hajnoczi Message-ID: <20141111171635.GA22150@stefanha-thinkpad.redhat.com> References: <1415666500-861-1-git-send-email-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="PEIAKu/WMn1b1Hv9" Content-Disposition: inline In-Reply-To: <1415666500-861-1-git-send-email-jsnow@redhat.com> Subject: Re: [Qemu-devel] [PATCH] ahci: Fix byte count regression for ATAPI/PIO List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com --PEIAKu/WMn1b1Hv9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 10, 2014 at 07:41:40PM -0500, John Snow wrote: > This patch fixes a regression caused by commit > 659142ecf71a0da240ab0ff7cf929ee25c32b9bc. > The problem occurs when we wish to return early > from the ahci_start_transfer function, but are now > updating the transferred byte count in the AHCI > command header via ahci_commit_buf. >=20 > This will cause problems in the Windows 8 installer. >=20 > Don't update the byte count in the command header > for the transmission of ATAPI packets: These commands > will distort the final byte count of the actual data > payload. >=20 > The call to ahci_commit_buf remains in the "out" > portion of the call in order to clean up the sglist. > The byte count is maintained by forcing size to be 0. >=20 > Signed-off-by: John Snow > --- > hw/ide/ahci.c | 1 + > 1 file changed, 1 insertion(+) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan --PEIAKu/WMn1b1Hv9 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUYkRzAAoJEJykq7OBq3PI5JMH/jOV1A9Af0mICLaXEPP4RUvq 2k0rSQM+3KXXzOprBpkVlbTx9nHMg2+2zyr4IJJPry0d5V6IaglIjKOz/XyCQH8k XX2jqZXfEkEzUNh9wgvtncF8dqOOFJvmFZRelEERSqBkz5zEJinbR698UME0TWWZ bBXYTfAy/6xp9tfmeEV5NZUvfyOz9TmYzsuF4lCwi61nYp0pfBZgw0SmH5pqwA9n IJGtUvhzONjI9YphIC7vUEvDjHH0g/ioF/wUYzuxpe54CNQ1l/NjOJMZBUSq0PUx GIccPNONgupzECMUnZcKB4eOfGXgvlEI+uJFN9KMs1ZRN7I8KaDLYTsZLI35nD4= =Eqvg -----END PGP SIGNATURE----- --PEIAKu/WMn1b1Hv9--