From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43568) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XoSoD-0005Yb-Gs for qemu-devel@nongnu.org; Wed, 12 Nov 2014 02:57:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XoSo9-0001Ft-5l for qemu-devel@nongnu.org; Wed, 12 Nov 2014 02:57:45 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54054) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XoSo8-0001ER-UZ for qemu-devel@nongnu.org; Wed, 12 Nov 2014 02:57:41 -0500 Date: Wed, 12 Nov 2014 08:57:29 +0100 From: Igor Mammedov Message-ID: <20141112085729.069bc8a8@nial.usersys.redhat.com> In-Reply-To: <5462BBF6.4040709@cn.fujitsu.com> References: <1409197002-9498-1-git-send-email-guz.fnst@cn.fujitsu.com> <5462BBF6.4040709@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC V2 00/10] cpu: add device_add foo-x86_64-cpu and i386 cpu hot remove support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gu Zheng Cc: qemu-devel@nongnu.org, tangchen@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, chen.fan.fnst@cn.fujitsu.com, anshul.makkar@profitbricks.com, afaerber@suse.de On Wed, 12 Nov 2014 09:46:30 +0800 Gu Zheng wrote: > Hi Igor, > As your hot-plug rework has been merged in upstream, and we need to respin > the i386 cpu hot remove a lot based on the latest tree. > So I want to split the series into two parts: > Part 1/2: add device_add foo-x86_64-cpu support. > Part 2/2: i386 cpu hot remove support. > , which will be easy to review. > The Part 1/2 will come soon, and Part 2/2 will be sent out once the rework > is done. > What's your opinion? It makes sence to me, plug it will be easier to review/ammend smaller serie= s. >=20 > Thanks, > Gu=20 >=20 > On 08/28/2014 11:36 AM, Gu Zheng wrote: >=20 > > This series is based on the previous patchset from Chen Fan: > > https://lists.nongnu.org/archive/html/qemu-devel/2014-05/msg02360.html > > https://lists.nongnu.org/archive/html/qemu-devel/2013-12/msg04266.html > >=20 > > Patch 1~3: add device_add foo-x86_64-cpu support > > These three patches try to make cpu hotplug with device_add, and make > > "-device foo-x86_64-cpu" available=EF=BC=8Calso we can set apic-id > > property with command line, if without setting apic-id property, > > we offer the first unoccupied apic id as the default new apic id. > > When hotplug cpu with device_add, additional check of APIC ID will be > > done after cpu object initialization which was different from > > 'cpu_add' command that check 'ids' at the beginning. > >=20 > > Patch 4~10: add i386 cpu hot remove support > > Via implementing ACPI standard methods _EJ0 in ACPI table, after Guest > > OS remove one vCPU online, the fireware will store removed bitmap to > > QEMU, then QEMU could know to notify the assigned vCPU of exiting. > > Meanwhile, intruduce the QOM command 'device_del' to remove vCPU from > > QEMU itself. > >=20 > > v2: > > -fix the cpu index duplicated issue in the QMP/HMP command output. > >=20 > > Chen Fan (6): > > cpu: introduce CpuTopoInfo structure for argument simplification > > cpu: add device_add foo-x86_64-cpu support > > x86: add x86_cpu_unrealizefn() for cpu apic remove > > qom cpu: rename variable 'cpu_added_notifier' to > > 'cpu_hotplug_notifier' > > i386: implement pc interface cpu_common_unrealizefn() in qom/cpu.c > > cpu hotplug: implement function cpu_status_write() for vcpu ejection > >=20 > > Gu Zheng (4): > > qom/cpu: move register_vmstate to common CPUClass.realizefn > > i386: add cpu device_del support > > qom cpu: add UNPLUG cpu notify support > > cpus: reclaim allocated vCPU objects > >=20 > > cpus.c | 48 +++++++++++++- > > exec.c | 32 +++++---- > > hw/acpi/cpu_hotplug.c | 55 +++++++++++++-- > > hw/acpi/ich9.c | 13 ++-- > > hw/acpi/piix4.c | 21 +++--- > > hw/i386/acpi-dsdt-cpu-hotplug.dsl | 6 ++- > > hw/i386/kvm/apic.c | 8 ++ > > hw/i386/pc.c | 2 +- > > hw/intc/apic.c | 10 +++ > > hw/intc/apic_common.c | 26 ++++++- > > include/hw/acpi/cpu_hotplug.h | 14 ++++- > > include/hw/acpi/ich9.h | 2 +- > > include/hw/cpu/icc_bus.h | 1 + > > include/hw/i386/apic_internal.h | 3 + > > include/qom/cpu.h | 12 +++ > > include/sysemu/kvm.h | 1 + > > include/sysemu/sysemu.h | 2 +- > > kvm-all.c | 57 +++++++++++++++- > > monitor.c | 4 +- > > qdev-monitor.c | 1 + > > qom/cpu.c | 29 +++++++-- > > target-i386/cpu-qom.h | 1 + > > target-i386/cpu.c | 138 +++++++++++++++++++++++++++++= +++++++- > > target-i386/topology.h | 51 +++++++++---- > > 24 files changed, 470 insertions(+), 67 deletions(-) > >=20 >=20 >=20 >=20