From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48832) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xol4w-0006ou-7j for qemu-devel@nongnu.org; Wed, 12 Nov 2014 22:28:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xol4q-00022I-Ou for qemu-devel@nongnu.org; Wed, 12 Nov 2014 22:28:13 -0500 Received: from ozlabs.org ([103.22.144.67]:48979) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xol4q-00021z-Ez for qemu-devel@nongnu.org; Wed, 12 Nov 2014 22:28:08 -0500 Date: Thu, 13 Nov 2014 14:29:15 +1100 From: David Gibson Message-ID: <20141113032915.GG7291@voom.fritz.box> References: <1412358473-31398-1-git-send-email-dgilbert@redhat.com> <1412358473-31398-46-git-send-email-dgilbert@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="jt0yj30bxbg11sci" Content-Disposition: inline In-Reply-To: <1412358473-31398-46-git-send-email-dgilbert@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 45/47] Start up a postcopy/listener thread ready for incoming page data List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, lilei@linux.vnet.ibm.com, quintela@redhat.com, cristian.klein@cs.umu.se, qemu-devel@nongnu.org, amit.shah@redhat.com, yanghy@cn.fujitsu.com --jt0yj30bxbg11sci Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 03, 2014 at 06:47:51PM +0100, Dr. David Alan Gilbert (git) wrot= e: > From: "Dr. David Alan Gilbert" >=20 > The loading of a device state (during postcopy) may access guest > memory that's still on the source machine and thus might need > a page fill; split off a separate thread that handles the incoming > page data so that the original incoming migration code can finish > off the device data. >=20 > Signed-off-by: Dr. David Alan Gilbert > --- > include/migration/migration.h | 4 +++ > migration.c | 6 +++++ > savevm.c | 62 +++++++++++++++++++++++++++++++++++++= ++++-- > 3 files changed, 70 insertions(+), 2 deletions(-) >=20 > diff --git a/include/migration/migration.h b/include/migration/migration.h > index 00255b8..69e776c 100644 > --- a/include/migration/migration.h > +++ b/include/migration/migration.h > @@ -92,6 +92,10 @@ struct MigrationIncomingState { > QemuThread fault_thread; > QemuSemaphore fault_thread_sem; > =20 > + bool have_listen_thread; AFAICT have_listen_thread is never set to a value other than 'true', so there doesn't see much point to it. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --jt0yj30bxbg11sci Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUZCWLAAoJEGw4ysog2bOSdpcQAIDgQFhlgD+lsg4KijGg6elZ 0xjrlEGtD2swePy7TMj4Gzhlog16vVS2auu1d+UMdBmyixhmg6dTjFBkPosQHWTv VNTXVDR47KDhQB7amQB67ek1fuqCo4Hs+7sm326+M5ndfzzfD9LbXNLAlBlaR0a9 cUCb7agEeGbbEcBJP5jeInCuRgiuVKZJDIDzIwD5F7vsOtqUYw8Xm38KN6rGSgA8 gqRBsuDxr5TJefP7sGZcFFkTplSpmXkbyODrXzw8bbAfwngx+mw+nl6PAMlJY9rM zPS8lQ2WOy1APR/Xt2sr0zDi8aPbdMPaGaWZj2i7ju17Fnsd0s2wEE3kxSzrfkDZ TPN+aKujQfUqNlJ9dOogEjwIemyJcFTYS5BXjlUsk0XZZPMq94pVOEw5Ut+49ten dKOHt5UDBazeQ8txnroHRu8uOk5httxji0qbv3S8LRjGQqMIz86QUti5ypH2kCJS WqdcxR2kNiPsT+7tT9gASyn+GYyYDeaTsJH1/l74TIWURutn5WyRhrRxZzS8zPTM cNeJxq9Seiz9lyP/K6loZdswfGA02ZtuRD0/Aidv0ScJn3aJiyQjIbc1Uo9+DIWD 4pbPSz7/W9rTewjbmMYBaRUPo/07rFjgqtvZpruaPi9Ep/5JQsjTelK1bBny7JwH JumBnrOlQwB7STof2Kjw =TuGg -----END PGP SIGNATURE----- --jt0yj30bxbg11sci--