From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38110) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XorGi-0004QD-I6 for qemu-devel@nongnu.org; Thu, 13 Nov 2014 05:04:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XorGd-0008UE-32 for qemu-devel@nongnu.org; Thu, 13 Nov 2014 05:04:48 -0500 Received: from mail-wg0-x232.google.com ([2a00:1450:400c:c00::232]:36901) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XorGc-0008U8-Rw for qemu-devel@nongnu.org; Thu, 13 Nov 2014 05:04:43 -0500 Received: by mail-wg0-f50.google.com with SMTP id z12so16385280wgg.9 for ; Thu, 13 Nov 2014 02:04:41 -0800 (PST) Date: Thu, 13 Nov 2014 10:04:39 +0000 From: Stefan Hajnoczi Message-ID: <20141113100439.GA32079@stefanha-thinkpad.redhat.com> References: <1414785819-26209-1-git-send-email-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="qMm9M+Fa2AknHoGS" Content-Disposition: inline In-Reply-To: <1414785819-26209-1-git-send-email-jsnow@redhat.com> Subject: Re: [Qemu-devel] [block PATCH v2 0/3] AHCI device fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, armbru@redhat.com --qMm9M+Fa2AknHoGS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 31, 2014 at 04:03:36PM -0400, John Snow wrote: > This is a v2 patch series that collects patches 3, 4 and 5 > from the v1 series that was only partially merged. >=20 > This series, as a subset, generally cleans up the usage and > handling of the scatter-gather list implementation in QEMU > that interacts with the PRDT (Physical Region Descriptor Table) > in AHCI. >=20 > We also repair a small oversight with PIO transfers. >=20 > This series currently applies cleanly to stefanha's block staging > tree, but can be trivially merged to master. >=20 > v2: > - Reset io_buffer_offset to 0 at the beginning of ide_exec_cmd, > which will reset it for PIO I/O and all ATAPI commands. > There was an oversight in V1 where we would use junk values for > PACKET IDENTIFY if it was not the first command. >=20 > - Adjust the prepare_buf() callback to return, simply, the number > of bytes it was able to prepare, or -1 on error. This resolves > an ambiguity around the nature of its return code meaning > "no sectors" or "no bytes" which led to bad error pathways. >=20 > John Snow (3): > ide: repair PIO transfers for cases where nsector > 1 > ahci: unify sglist preparation > ide: Correct handling of malformed/short PRDTs >=20 > hw/ide/ahci.c | 33 ++++++++++++++++++++++++++------- > hw/ide/core.c | 14 ++++++++++++-- > hw/ide/internal.h | 13 +++++++------ > hw/ide/macio.c | 7 ++++++- > hw/ide/pci.c | 27 +++++++++++++++++++++------ > 5 files changed, 72 insertions(+), 22 deletions(-) >=20 > --=20 > 1.9.3 >=20 >=20 Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan --qMm9M+Fa2AknHoGS Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEbBAEBAgAGBQJUZII3AAoJEJykq7OBq3PIsqgH92mEQxPAKvaO/68CHzuqGSdP oRI5Cnt6ip36IzCHW7GYw9NdVXQbPwFz0sawj2SGI2JMSZ1WxUPcKIxENzMyJrx1 vYYnzVDev8e02RtqznNGDHkc0FJV9fgcDZ/cn5eG8BN5fs9ZPNYn7YWmIwFBJbxk yFoC5nXt1ZTKysHrPxIL+LS+QbjNCBCX9LlEg3Jl9mYL3XArcqhCvotkLRREDcUr KSUjeDZzarEXaTR365DUoeV6tPBSnbAZpTwlTavG/Et053ZeQvvx3ZkYY/yoHfBm 5DA+IRfD+6tHTjK647LlMw30rrLVAPza65fZbPfq8bXsM6eBmgDTJtwQNLwMxg== =nA3b -----END PGP SIGNATURE----- --qMm9M+Fa2AknHoGS--