From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39317) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XorKY-0008DW-EO for qemu-devel@nongnu.org; Thu, 13 Nov 2014 05:08:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XorKT-0001be-RV for qemu-devel@nongnu.org; Thu, 13 Nov 2014 05:08:46 -0500 Received: from mail-wi0-x234.google.com ([2a00:1450:400c:c05::234]:48505) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XorKT-0001bX-Jr for qemu-devel@nongnu.org; Thu, 13 Nov 2014 05:08:41 -0500 Received: by mail-wi0-f180.google.com with SMTP id hi2so7659507wib.7 for ; Thu, 13 Nov 2014 02:08:41 -0800 (PST) Date: Thu, 13 Nov 2014 10:08:37 +0000 From: Stefan Hajnoczi Message-ID: <20141113100837.GA4920@stefanha-thinkpad.redhat.com> References: <1415058979-16604-1-git-send-email-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Q68bSM7Ycu6FN28Q" Content-Disposition: inline In-Reply-To: <1415058979-16604-1-git-send-email-jsnow@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/5] ahci: fis decomposition improvements List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: kwolf@redhat.com, mst@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com --Q68bSM7Ycu6FN28Q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 03, 2014 at 06:56:14PM -0500, John Snow wrote: > This patch series may require, and is based on another > AHCI series pending on-list: > http://lists.gnu.org/archive/html/qemu-devel/2014-10/msg04143.html >=20 > This series aims to improve the way that handle_cmd > reads and behaves in interpreting the FIS packets > received by the AHCI HBA. This series used to be > part of a larger RFC, but has since been pared > down to a more focused series. >=20 > Previous RFC: > http://lists.gnu.org/archive/html/qemu-devel/2014-09/msg02694.html >=20 > Patch 1 is a subset of the previously posted > "AHCI: Rename NCQFIS structure fields" patch. > This subset is just aimed at improving the readability > of the FIS decomposition in handle_cmd for now. >=20 > Patch 2 is nearly the same as "AHCI: Fix FIS decomposition" > which has yet to be reviewed. >=20 > Patches 3, 4, and 5 have been inspected previously, and should > be identical. > "ide/ahci: Reorder error cases in handle_cmd" > "ahci: Check cmd_fis[1] more explicitly" > "ahci: factor out FIS decomposition" >=20 > John Snow (5): > ahci: add is_ncq predicate helper > AHCI: Fix FIS decomposition > ahci: Reorder error cases in handle_cmd > ahci: Check cmd_fis[1] more explicitly > ahci: factor out FIS decomposition from handle_cmd >=20 > hw/ide/ahci.c | 233 ++++++++++++++++++++++++++++++----------------------= ------ > hw/ide/ahci.h | 3 + > 2 files changed, 125 insertions(+), 111 deletions(-) >=20 > --=20 > 1.9.3 >=20 >=20 Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan --Q68bSM7Ycu6FN28Q Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUZIMlAAoJEJykq7OBq3PI7mgH/ishquPyTH4T/QcdL+ZNjrxK L86s+fiWUD1rj+VD60n5foaqSi6iWmGdj3/TkQq8CVdAv51/30bw0c+z5LN1aDlX OytykihPOYFM69USgPy+tbXoQesKjXnk+8pYAuETcPbO230S4uNC6KAhwz4M8XL3 dP+OmzBpebe9dtEUHCQKZMrHTzp5cDK/Y/WgosqyAiAMAcfw2FtvNAsqqV8oxLD0 DiM4HFg7hjDiPslIxin9zU5BJLK09LHwYltYnH87DNRgsov46f+0KPLT4uC1mzgA 9Yg1Dm4ZJAxm40ZcqMKLNZcwXwpWEY2DuEpNxO6TsCJ1AivI7+/9X0q2vCrVNeE= =L7qR -----END PGP SIGNATURE----- --Q68bSM7Ycu6FN28Q--