From: Stefan Hajnoczi <stefanha@gmail.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: jcody@redhat.com, mreitz@redhat.com, qemu-devel@nongnu.org,
stefanha@redhat.com, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 2/9] qemu-iotests: Use qemu-io -f $IMGFMT
Date: Thu, 13 Nov 2014 10:47:28 +0000 [thread overview]
Message-ID: <20141113104728.GD7462@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1415389165-16157-3-git-send-email-kwolf@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1109 bytes --]
On Fri, Nov 07, 2014 at 08:39:18PM +0100, Kevin Wolf wrote:
> This patch changes $QEMU_IO so that all tests by default pass a format
> argument to qemu-io.
>
> There are a few cases where -f $IMGFMT is not wanted because it selects
> the wrong driver or json: filenames including a driver are used. They
> are changed to use $QEMU_IO_PROG, which doesn't include any options.
>
> Tests 071 and 081 have output changes because now the actual request
> fails instead of reading the 2k probing buffer.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> tests/qemu-iotests/016 | 11 +++++++----
> tests/qemu-iotests/048 | 2 +-
> tests/qemu-iotests/058 | 11 +++++++----
> tests/qemu-iotests/071 | 10 +++++-----
> tests/qemu-iotests/071.out | 6 +++---
> tests/qemu-iotests/077 | 2 +-
> tests/qemu-iotests/081 | 8 ++++++--
> tests/qemu-iotests/081.out | 2 +-
> tests/qemu-iotests/089 | 6 ++++--
> tests/qemu-iotests/common | 2 +-
> 10 files changed, 36 insertions(+), 24 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-11-13 10:47 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 19:39 [Qemu-devel] [PATCH v2 0/9] raw: Prohibit dangerous writes for probed images Kevin Wolf
2014-11-07 19:39 ` [Qemu-devel] [PATCH v2 1/9] qemu-io: Allow explicitly specifying format Kevin Wolf
2014-11-10 14:07 ` Max Reitz
2014-11-10 14:18 ` Max Reitz
2014-11-10 19:24 ` Eric Blake
2014-11-13 10:47 ` Stefan Hajnoczi
2014-11-07 19:39 ` [Qemu-devel] [PATCH v2 2/9] qemu-iotests: Use qemu-io -f $IMGFMT Kevin Wolf
2014-11-10 14:21 ` Max Reitz
2014-11-13 10:47 ` Stefan Hajnoczi [this message]
2014-11-07 19:39 ` [Qemu-devel] [PATCH v2 3/9] qemu-iotests: Add qemu-io format option in Python tests Kevin Wolf
2014-11-10 14:29 ` Max Reitz
2014-11-10 14:33 ` Kevin Wolf
2014-11-13 10:47 ` Stefan Hajnoczi
2014-11-07 19:39 ` [Qemu-devel] [PATCH v2 4/9] qtests: Specify image format explicitly Kevin Wolf
2014-11-10 14:39 ` Max Reitz
2014-11-13 10:47 ` Stefan Hajnoczi
2014-11-07 19:39 ` [Qemu-devel] [PATCH v2 5/9] block: Factor bdrv_probe_all() out of find_image_format() Kevin Wolf
2014-11-10 14:47 ` Max Reitz
2014-11-13 10:47 ` Stefan Hajnoczi
2014-11-07 19:39 ` [Qemu-devel] [PATCH v2 6/9] block: Read only one sector for format probing Kevin Wolf
2014-11-10 14:48 ` Max Reitz
2014-11-13 10:36 ` Stefan Hajnoczi
2014-11-07 19:39 ` [Qemu-devel] [PATCH v2 7/9] raw: Prohibit dangerous writes for probed images Kevin Wolf
2014-11-10 15:03 ` Max Reitz
2014-11-10 19:51 ` Eric Blake
2014-11-13 10:46 ` Stefan Hajnoczi
2014-11-07 19:39 ` [Qemu-devel] [PATCH v2 8/9] qemu-iotests: Fix stderr handling in common.qemu Kevin Wolf
2014-11-10 15:04 ` Max Reitz
2014-11-10 19:55 ` Eric Blake
2014-11-13 10:48 ` Stefan Hajnoczi
2014-11-07 19:39 ` [Qemu-devel] [PATCH v2 9/9] qemu-iotests: Test writing non-raw image headers to raw image Kevin Wolf
2014-11-10 15:53 ` Max Reitz
2014-11-10 20:00 ` Eric Blake
2014-11-13 10:48 ` Stefan Hajnoczi
2014-11-10 20:02 ` [Qemu-devel] [PATCH v2 0/9] raw: Prohibit dangerous writes for probed images Eric Blake
2014-11-11 10:03 ` Markus Armbruster
2014-11-13 10:49 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141113104728.GD7462@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=armbru@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).