From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56099)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1XosRq-0007d0-5d
	for qemu-devel@nongnu.org; Thu, 13 Nov 2014 06:20:31 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1XosRh-0007Sd-5A
	for qemu-devel@nongnu.org; Thu, 13 Nov 2014 06:20:22 -0500
Received: from mail-wi0-x231.google.com ([2a00:1450:400c:c05::231]:36465)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1XosRg-0007SU-UM
	for qemu-devel@nongnu.org; Thu, 13 Nov 2014 06:20:13 -0500
Received: by mail-wi0-f177.google.com with SMTP id l15so3972551wiw.10
	for <qemu-devel@nongnu.org>; Thu, 13 Nov 2014 03:20:12 -0800 (PST)
Date: Thu, 13 Nov 2014 11:20:09 +0000
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20141113112009.GL7462@stefanha-thinkpad.redhat.com>
References: <D0890790.3A5A%gary.hook@nimboxx.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="FnOKg9Ah4tDwTfQS"
Content-Disposition: inline
In-Reply-To: <D0890790.3A5A%gary.hook@nimboxx.com>
Subject: Re: [Qemu-devel] [PATCH 1/1] block migration: fix return value
 mismatch
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gary Hook <gary.hook@nimboxx.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>


--FnOKg9Ah4tDwTfQS
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Nov 12, 2014 at 06:48:18PM +0000, Gary Hook wrote:
> -    return qemu_ftell(f) - last_ftell;
> +    delta_ftell = qemu_ftell(f) - last_ftell;
> +    return( (delta_ftell > 0) ? 1 : (delta_ftell < 0) ? -1 : 0 );

Good find!

Please don't nest the ternary operator, it is hard to read.

if (delta_ftell < 0) {
    return -1;
} else if (delta_ftell > 0) {
    return 1;
} else {
    return 0;
}

--FnOKg9Ah4tDwTfQS
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJUZJPpAAoJEJykq7OBq3PIfzIIAKfgpr1sw/Y/SQN0GVj3vvqf
O6G9PHqcHXPH94BILQZs+TTcC78neBURUbr0TwIeY3kvfHooTc0zJAYb5zTFSt8e
74gjOM6fyTAgrUMV+DmGopiScEnqPFcnML83TPwXVCaqYkM4shkK6E7ByDLktbSS
jO6kbHh/c32JM/XcItMMhZEc05uHXZ+g0sIVh7vA8YDHegost6p29/T822lO8OX4
sxMlm5EojcNUATtKzf04TwlnQaZaj4T7BlwUpjpkeZIY+cpKFv4lnFwvfvuQ/h+W
QrteU1Tv9pOutWHlKj+uob144P2nO9PjPZ5qIrK5X+97TQ1VusN3vhZpm4qZaXE=
=s2a6
-----END PGP SIGNATURE-----

--FnOKg9Ah4tDwTfQS--