From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58180) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xosbl-0006v2-Uz for qemu-devel@nongnu.org; Thu, 13 Nov 2014 06:30:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xosbc-0002OK-UE for qemu-devel@nongnu.org; Thu, 13 Nov 2014 06:30:37 -0500 Received: from mail-wi0-x234.google.com ([2a00:1450:400c:c05::234]:50213) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xosbc-0002OF-OC for qemu-devel@nongnu.org; Thu, 13 Nov 2014 06:30:28 -0500 Received: by mail-wi0-f180.google.com with SMTP id hi2so7886042wib.13 for ; Thu, 13 Nov 2014 03:30:28 -0800 (PST) Date: Thu, 13 Nov 2014 11:30:25 +0000 From: Stefan Hajnoczi Message-ID: <20141113113025.GO7462@stefanha-thinkpad.redhat.com> References: <1415858145-23461-1-git-send-email-jasowang@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="0lsrIB+s628ok5gC" Content-Disposition: inline In-Reply-To: <1415858145-23461-1-git-send-email-jasowang@redhat.com> Subject: Re: [Qemu-devel] [PATCH] virtio-net: correctly advertise host features List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Wang Cc: qemu-devel@nongnu.org, aliguori@amazon.com, mst@redhat.com --0lsrIB+s628ok5gC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Nov 13, 2014 at 01:55:45PM +0800, Jason Wang wrote: > We should not advertise the feature that depends on ctrl vq is it was not > enabled. And not advertise the VIRTIO_NET_F_CTRL_RX_EXTRA is s/is/if/ > VIRTIO_NET_F_CTRL_RX is not enabled. s/is/it/ These can be fixed up while merging. --0lsrIB+s628ok5gC Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUZJZRAAoJEJykq7OBq3PIZy0IAK1Ts+Z2D9+fDGozKCc88dt/ YylNNSl2LVD+NDjQ1FWNOe4Ci0Q2G+UjkukPxNkGqMILoY8ZIQjIEaN+MFF45hMP teTXzUHQFU6co9so74TkNeB5cKdldek+FZWTk8XtacbYhD2LstbuQFh8EM4h+AWR KWyeRoPIJXgNvaExpTsDLTZ7uwWdwBVIPzeG3GCxu/F/rJZtDrqGrErDiwogdsH/ aFGvE013VjZOZa9WZXPvY5ICR9uuWsDii+RwKZBHZzI6pPv/DgxXsKR9btLqC5EU QRwhCQsSu/0aHjX0r0a1P7EsKDGKJiCY2h0G+HnEzYqa8cs9mZ3uWf+44JV8wZE= =PbS/ -----END PGP SIGNATURE----- --0lsrIB+s628ok5gC--