Re: [Qemu-devel] [PATCH v3 1/1] virtio: serial: expose a 'guest_writable' callback for users

[Amit Shah <amit.shah@redhat.com>]

On (Thu) 13 Nov 2014 [15:47:12], Gerd Hoffmann wrote:
> On Di, 2014-10-28 at 20:21 +0530, Amit Shah wrote:
> > Users of virtio-serial may want to know when a port becomes writable.  A
> > port can stop accepting writes if the guest port is open but not being
> > read from.  In this case, data gets queued up in the virtqueue, and
> > after the vq is full, writes to the port do not succeed.
> > 
> > When the guest reads off a vq element, and adds a new one for the host
> > to put data in, we can tell users the port is available for more writes,
> > via the new ->guest_writable() callback.
> > 
> > Signed-off-by: Amit Shah <amit.shah@redhat.com>
> 
> What is the plan with that one?  I have some spice patches sitting in a
> branch depending on this one.  Should it go through virtio queue?  With
> some ack from virtio I can also take it through the spice queue,
> together with the other patches depending on this one.

I will push it through my tree when 2.3 opens.

> It fails checkpatch btw:

Yes, v4 (in the pull req) corrected this.

Thanks,

		Amit