From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51728)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1Xp5zu-0001qj-PD
	for qemu-devel@nongnu.org; Thu, 13 Nov 2014 20:48:33 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1Xp5zn-0003X9-Sj
	for qemu-devel@nongnu.org; Thu, 13 Nov 2014 20:48:26 -0500
Received: from mx1.redhat.com ([209.132.183.28]:52334)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1Xp5zn-0003Wu-L5
	for qemu-devel@nongnu.org; Thu, 13 Nov 2014 20:48:19 -0500
Date: Fri, 14 Nov 2014 07:18:08 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20141114014808.GF14495@grmbl.mre>
References: <ac7a182659785c39058896b7466cf6865c6ae58f.1414507889.git.amit.shah@redhat.com>
	<1415890032.25539.19.camel@nilsson.home.kraxel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1415890032.25539.19.camel@nilsson.home.kraxel.org>
Subject: Re: [Qemu-devel] [PATCH v3 1/1] virtio: serial: expose a
 'guest_writable' callback for users
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Amos Kong <akong@redhat.com>, qemu list <qemu-devel@nongnu.org>, marcandre.lureau@redhat.com, Markus Armbruster <armbru@redhat.com>

On (Thu) 13 Nov 2014 [15:47:12], Gerd Hoffmann wrote:
> On Di, 2014-10-28 at 20:21 +0530, Amit Shah wrote:
> > Users of virtio-serial may want to know when a port becomes writable.  A
> > port can stop accepting writes if the guest port is open but not being
> > read from.  In this case, data gets queued up in the virtqueue, and
> > after the vq is full, writes to the port do not succeed.
> > 
> > When the guest reads off a vq element, and adds a new one for the host
> > to put data in, we can tell users the port is available for more writes,
> > via the new ->guest_writable() callback.
> > 
> > Signed-off-by: Amit Shah <amit.shah@redhat.com>
> 
> What is the plan with that one?  I have some spice patches sitting in a
> branch depending on this one.  Should it go through virtio queue?  With
> some ack from virtio I can also take it through the spice queue,
> together with the other patches depending on this one.

I will push it through my tree when 2.3 opens.

> It fails checkpatch btw:

Yes, v4 (in the pull req) corrected this.

Thanks,

		Amit