qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: zhanghailiang <zhang.zhanghailiang@huawei.com>
Cc: imammedo@redhat.com, qemu-devel@nongnu.org, peter.huangpeng@huawei.com
Subject: Re: [Qemu-devel] [PATCH v2 0/3] fix bug about balloon working incorrectly when hotplug memeory
Date: Mon, 17 Nov 2014 12:39:57 +0200	[thread overview]
Message-ID: <20141117103957.GB20638@redhat.com> (raw)
In-Reply-To: <1416201070-11448-1-git-send-email-zhang.zhanghailiang@huawei.com>

On Mon, Nov 17, 2014 at 01:11:07PM +0800, zhanghailiang wrote:
> Hi,
> 
> Patch 1 and 2 mainly fix bug about balloon not working correctly when we do
> hotplug memory. It takes 'ram_size' as VM's real RAM size which is wrong
> after we hotplug memory.
> 
> This bug exists since we begin to support hotplug memory, and it is better
> to fix it.
> 
> Patch 3 add some trace events, it helps debugging balloon. If it is unnecessary, 
> pls feel free to remove it.
> 
> Thanks,
> zhanghailiang

What about other users of ram_size?
Are they all incorrect?

> v2:
> - fix compiling break for other targets that don't support pc-dimm
> 
> zhanghailiang (3):
>   pc-dimm: add a function to calculate VM's current RAM size
>   virtio-balloon: Fix balloon not working correctly when hotplug memory
>   virtio-balloon: Add some trace events
> 
>  hw/mem/pc-dimm.c                | 26 ++++++++++++++++++++++++++
>  hw/virtio/virtio-balloon.c      | 21 +++++++++++++++------
>  include/exec/cpu-common.h       |  1 +
>  stubs/qmp_pc_dimm_device_list.c |  5 +++++
>  trace-events                    |  4 ++++
>  5 files changed, 51 insertions(+), 6 deletions(-)
> 
> -- 
> 1.7.12.4
> 

  parent reply	other threads:[~2014-11-17 10:40 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-17  5:11 [Qemu-devel] [PATCH v2 0/3] fix bug about balloon working incorrectly when hotplug memeory zhanghailiang
2014-11-17  5:11 ` [Qemu-devel] [PATCH v2 1/3] pc-dimm: add a function to calculate VM's current RAM size zhanghailiang
2014-11-19  9:59   ` Igor Mammedov
2014-11-19 10:32   ` Michael S. Tsirkin
2014-11-19 15:13     ` Luiz Capitulino
2014-11-19 15:52       ` Eric Blake
2014-11-19 16:06         ` Michael S. Tsirkin
2014-11-19 16:31           ` Eric Blake
2014-11-20  2:31             ` zhanghailiang
2014-11-20  9:10             ` Michael S. Tsirkin
2014-11-20  2:33     ` zhanghailiang
2014-11-17  5:11 ` [Qemu-devel] [PATCH v2 2/3] virtio-balloon: Fix balloon not working correctly when hotplug memory zhanghailiang
2014-11-17  5:11 ` [Qemu-devel] [PATCH v2 3/3] virtio-balloon: Add some trace events zhanghailiang
2014-11-17  6:07 ` [Qemu-devel] [PATCH v2 0/3] fix bug about balloon working incorrectly when hotplug memeory Michael S. Tsirkin
2014-11-17 10:39 ` Michael S. Tsirkin [this message]
2014-11-17 10:53   ` zhanghailiang
2014-11-17 12:25     ` zhanghailiang
2014-11-17 12:40       ` Michael S. Tsirkin
2014-11-18  2:50         ` zhanghailiang
2014-11-19  8:28 ` zhanghailiang
2014-11-19 10:06   ` Igor Mammedov
2015-03-03 14:04 ` Luiz Capitulino
2015-03-04 12:55   ` zhanghailiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141117103957.GB20638@redhat.com \
    --to=mst@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=peter.huangpeng@huawei.com \
    --cc=qemu-devel@nongnu.org \
    --cc=zhang.zhanghailiang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).