From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45130) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqJjG-0003My-NL for qemu-devel@nongnu.org; Mon, 17 Nov 2014 05:40:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XqJjA-0001dy-F5 for qemu-devel@nongnu.org; Mon, 17 Nov 2014 05:40:18 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50487) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqJjA-0001du-7g for qemu-devel@nongnu.org; Mon, 17 Nov 2014 05:40:12 -0500 Date: Mon, 17 Nov 2014 12:39:57 +0200 From: "Michael S. Tsirkin" Message-ID: <20141117103957.GB20638@redhat.com> References: <1416201070-11448-1-git-send-email-zhang.zhanghailiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1416201070-11448-1-git-send-email-zhang.zhanghailiang@huawei.com> Subject: Re: [Qemu-devel] [PATCH v2 0/3] fix bug about balloon working incorrectly when hotplug memeory List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: zhanghailiang Cc: imammedo@redhat.com, qemu-devel@nongnu.org, peter.huangpeng@huawei.com On Mon, Nov 17, 2014 at 01:11:07PM +0800, zhanghailiang wrote: > Hi, > > Patch 1 and 2 mainly fix bug about balloon not working correctly when we do > hotplug memory. It takes 'ram_size' as VM's real RAM size which is wrong > after we hotplug memory. > > This bug exists since we begin to support hotplug memory, and it is better > to fix it. > > Patch 3 add some trace events, it helps debugging balloon. If it is unnecessary, > pls feel free to remove it. > > Thanks, > zhanghailiang What about other users of ram_size? Are they all incorrect? > v2: > - fix compiling break for other targets that don't support pc-dimm > > zhanghailiang (3): > pc-dimm: add a function to calculate VM's current RAM size > virtio-balloon: Fix balloon not working correctly when hotplug memory > virtio-balloon: Add some trace events > > hw/mem/pc-dimm.c | 26 ++++++++++++++++++++++++++ > hw/virtio/virtio-balloon.c | 21 +++++++++++++++------ > include/exec/cpu-common.h | 1 + > stubs/qmp_pc_dimm_device_list.c | 5 +++++ > trace-events | 4 ++++ > 5 files changed, 51 insertions(+), 6 deletions(-) > > -- > 1.7.12.4 >