Re: [Qemu-devel] [PATCH v2 4/5] libqos: Add malloc generic

[Stefan Hajnoczi <stefanha@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1319 bytes --]

On Sat, Nov 01, 2014 at 06:02:29PM +0100, Marc Marí wrote:
> This malloc is a basic interface implementation that works for any platform.
> It should be replaced in the future for a real malloc implementation for each
> of the platforms.
> 
> Signed-off-by: Marc Marí <marc.mari.barcelo@gmail.com>
> ---
>  tests/libqos/malloc-generic.c |   50 +++++++++++++++++++++++++++++++++++++++++
>  tests/libqos/malloc-generic.h |   21 +++++++++++++++++
>  2 files changed, 71 insertions(+)
>  create mode 100644 tests/libqos/malloc-generic.c
>  create mode 100644 tests/libqos/malloc-generic.h
> 
> diff --git a/tests/libqos/malloc-generic.c b/tests/libqos/malloc-generic.c
> new file mode 100644
> index 0000000..0049424
> --- /dev/null
> +++ b/tests/libqos/malloc-generic.c
> @@ -0,0 +1,50 @@
> +/*
> + * Basic libqos generic malloc support
> + *
> + * Copyright (c) 2014 Marc Marí
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2 or later.
> + * See the COPYING file in the top-level directory.
> + */
> +
> +#include "libqos/malloc-generic.h"
> +#include "libqos/malloc.h"
> +#include <glib.h>

Please always include system headers (<>) before user headers ("").
This ensures that QEMU's headers do not pollute the namespace or affect
system headers in any way.

[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]