From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33644) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqOGE-0002fL-6M for qemu-devel@nongnu.org; Mon, 17 Nov 2014 10:30:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XqOG5-00049B-0U for qemu-devel@nongnu.org; Mon, 17 Nov 2014 10:30:38 -0500 Received: from mail-wi0-x229.google.com ([2a00:1450:400c:c05::229]:54284) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqOG4-00048v-QO for qemu-devel@nongnu.org; Mon, 17 Nov 2014 10:30:28 -0500 Received: by mail-wi0-f169.google.com with SMTP id r20so2813546wiv.0 for ; Mon, 17 Nov 2014 07:30:28 -0800 (PST) Date: Mon, 17 Nov 2014 15:30:25 +0000 From: Stefan Hajnoczi Message-ID: <20141117153025.GH16192@stefanha-thinkpad.redhat.com> References: <1414861350-13099-1-git-send-email-marc.mari.barcelo@gmail.com> <1414861350-13099-5-git-send-email-marc.mari.barcelo@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="jRdC2OsRnuV8iIl8" Content-Disposition: inline In-Reply-To: <1414861350-13099-5-git-send-email-marc.mari.barcelo@gmail.com> Subject: Re: [Qemu-devel] [PATCH v2 4/5] libqos: Add malloc generic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marc =?iso-8859-1?Q?Mar=ED?= Cc: qemu-devel@nongnu.org, Stefan Hajnoczi , Andreas =?iso-8859-1?Q?F=E4rber?= --jRdC2OsRnuV8iIl8 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Nov 01, 2014 at 06:02:29PM +0100, Marc Mar=ED wrote: > This malloc is a basic interface implementation that works for any platfo= rm. > It should be replaced in the future for a real malloc implementation for = each > of the platforms. >=20 > Signed-off-by: Marc Mar=ED > --- > tests/libqos/malloc-generic.c | 50 +++++++++++++++++++++++++++++++++++= ++++++ > tests/libqos/malloc-generic.h | 21 +++++++++++++++++ > 2 files changed, 71 insertions(+) > create mode 100644 tests/libqos/malloc-generic.c > create mode 100644 tests/libqos/malloc-generic.h >=20 > diff --git a/tests/libqos/malloc-generic.c b/tests/libqos/malloc-generic.c > new file mode 100644 > index 0000000..0049424 > --- /dev/null > +++ b/tests/libqos/malloc-generic.c > @@ -0,0 +1,50 @@ > +/* > + * Basic libqos generic malloc support > + * > + * Copyright (c) 2014 Marc Mar=ED > + * > + * This work is licensed under the terms of the GNU GPL, version 2 or la= ter. > + * See the COPYING file in the top-level directory. > + */ > + > +#include "libqos/malloc-generic.h" > +#include "libqos/malloc.h" > +#include Please always include system headers (<>) before user headers (""). This ensures that QEMU's headers do not pollute the namespace or affect system headers in any way. --jRdC2OsRnuV8iIl8 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUahSRAAoJEJykq7OBq3PIG0YIAMDvWpp1L0YvR5x6/9Cx97P8 fliL6mXYG0f/YTIEnywxEPct6JhcLY8xmFKX7DwmHU5hGcNDQwzasmJpndlL0nDW ZkcN/1nRyN/A5tmnavvhr9YCIySKVe14Pq1ahJcDR5NabyiAx3Rn+CujSAVeFW4W Mr9c+m3INmmvVZ2ykBXMs47TC1RvR8uJ9+XOAmae75ZNLznuAE172Q1AMlzaOQZ4 7fd7G0HnZKK1PZZPXqOa+03CDB5QdPENNApCjm39hOuVQTEx8PASs8pUxRg802tb Wf7+LUseRUvxzBI0VYbXMo/sdgyBozFUPhvtpPpZ8HUfkIsWLF/1s/neQkgIGCk= =3grq -----END PGP SIGNATURE----- --jRdC2OsRnuV8iIl8--