From: Stefan Hajnoczi <stefanha@gmail.com>
To: arei.gonglei@huawei.com
Cc: weidong.huang@huawei.com, zhang.zhanghailiang@huawei.com,
qemu-trivial@nongnu.org, mjt@tls.msk.ru,
peter.huangpeng@huawei.com, qemu-devel@nongnu.org,
pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH 5/9] nvme: remove superfluous check
Date: Mon, 17 Nov 2014 16:55:50 +0000 [thread overview]
Message-ID: <20141117165550.GN16192@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1416046008-7880-6-git-send-email-arei.gonglei@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 552 bytes --]
On Sat, Nov 15, 2014 at 06:06:44PM +0800, arei.gonglei@huawei.com wrote:
> From: Gonglei <arei.gonglei@huawei.com>
>
> Operands don't affect result (CONSTANT_EXPRESSION_RESULT)
> ((n->bar.aqa >> AQA_ASQS_SHIFT) & AQA_ASQS_MASK) > 4095
> is always false regardless of the values of its operands.
> This occurs as the logical second operand of '||'.
>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
> hw/block/nvme.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-11-17 16:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-15 10:06 [Qemu-devel] [PATCH 0/9] Fix Coverity warning reports arei.gonglei
2014-11-15 10:06 ` [Qemu-devel] [PATCH 1/9] l2tpv3: fix fd leak arei.gonglei
2014-11-17 16:51 ` Stefan Hajnoczi
2014-11-17 16:58 ` Michael Tokarev
2014-11-18 7:50 ` Markus Armbruster
2014-11-18 8:07 ` Gonglei
2014-11-15 10:06 ` [Qemu-devel] [PATCH 2/9] mips_mipssim: fix use-after-free for filename arei.gonglei
2014-11-15 10:06 ` [Qemu-devel] [PATCH 3/9] qga: fix false negative argument passing arei.gonglei
2014-11-15 10:06 ` [Qemu-devel] [PATCH 4/9] loader: fix NEGATIVE_RETURNS arei.gonglei
2014-11-15 10:06 ` [Qemu-devel] [PATCH 5/9] nvme: remove superfluous check arei.gonglei
2014-11-17 16:55 ` Stefan Hajnoczi [this message]
2014-11-15 10:06 ` [Qemu-devel] [PATCH 6/9] acl: fix memory leak arei.gonglei
2014-11-17 10:48 ` Paolo Bonzini
2014-11-15 10:06 ` [Qemu-devel] [PATCH 7/9] qemu-char: fix MISSING_COMMA arei.gonglei
2014-11-15 10:06 ` [Qemu-devel] [PATCH 8/9] shpc: fix dead code arei.gonglei
2014-11-15 10:06 ` [Qemu-devel] [PATCH 9/9] hcd-musb: fix dereference null return value arei.gonglei
2014-11-17 10:58 ` Paolo Bonzini
2014-11-17 11:18 ` Gonglei
2014-11-17 12:55 ` Gonglei
2014-11-17 13:36 ` Gerd Hoffmann
2014-11-17 13:39 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141117165550.GN16192@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=arei.gonglei@huawei.com \
--cc=mjt@tls.msk.ru \
--cc=pbonzini@redhat.com \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=weidong.huang@huawei.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).