From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34585)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1XqPaq-0006tY-TK
	for qemu-devel@nongnu.org; Mon, 17 Nov 2014 11:56:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1XqPal-0001Pg-Bw
	for qemu-devel@nongnu.org; Mon, 17 Nov 2014 11:56:00 -0500
Date: Mon, 17 Nov 2014 16:55:50 +0000
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20141117165550.GN16192@stefanha-thinkpad.redhat.com>
References: <1416046008-7880-1-git-send-email-arei.gonglei@huawei.com>
	<1416046008-7880-6-git-send-email-arei.gonglei@huawei.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="Ll0BBk1HBk/f94B0"
Content-Disposition: inline
In-Reply-To: <1416046008-7880-6-git-send-email-arei.gonglei@huawei.com>
Subject: Re: [Qemu-devel] [PATCH 5/9] nvme: remove superfluous check
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: arei.gonglei@huawei.com
Cc: weidong.huang@huawei.com, zhang.zhanghailiang@huawei.com, qemu-trivial@nongnu.org, mjt@tls.msk.ru, peter.huangpeng@huawei.com, qemu-devel@nongnu.org, pbonzini@redhat.com


--Ll0BBk1HBk/f94B0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Nov 15, 2014 at 06:06:44PM +0800, arei.gonglei@huawei.com wrote:
> From: Gonglei <arei.gonglei@huawei.com>
>=20
> Operands don't affect result (CONSTANT_EXPRESSION_RESULT)
> ((n->bar.aqa >> AQA_ASQS_SHIFT) & AQA_ASQS_MASK) > 4095
> is always false regardless of the values of its operands.
> This occurs as the logical second operand of '||'.
>=20
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
>  hw/block/nvme.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

--Ll0BBk1HBk/f94B0
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJUaiiWAAoJEJykq7OBq3PI1ywH/13plAcDGgXRrsbb8a3u+7Mo
mZ1UpK2oImsHY/yJMJI5mQQjHcIreOhzchnnibeiy+pK44RpnEihh8SGkBQa14CB
iTrhZfmkZlv/7aih2gw5guIErxFh9uxOhG51qXFk1t7s9/3wjjNDvzK/au7LFYGr
9hIYudGutPGgr/EQUSkRAWmZ+pnt1UUIyv2jzNrnGicIAxsjox4FTLmnrt2cYiaI
WNrE0Ruu/Hjtkoh3wqtIUtNns0lpBAAEIa53gZpV0SS/GxD+ISVzLz9ViWZsMWMN
dOXs+y2NyLyK9ovgG/CADK6/LSidghNgdEDdyXih+/+qsSavVq0BVt96Ho/Fvzw=
=fhU9
-----END PGP SIGNATURE-----

--Ll0BBk1HBk/f94B0--