From: Amit Shah <amit.shah@redhat.com>
To: dcb <1393486@bugs.launchpad.net>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Bug 1393486] [NEW] hw/virtio/virtio-rng.c:150: bad test ?
Date: Tue, 18 Nov 2014 14:11:39 +0530 [thread overview]
Message-ID: <20141118084139.GA9190@grmbl.mre> (raw)
In-Reply-To: <20141117171503.13080.40393.malonedeb@soybean.canonical.com>
On (Mon) 17 Nov 2014 [17:15:03], dcb wrote:
> Public bug reported:
>
> hw/virtio/virtio-rng.c:150:31: warning: logical not is only applied to
> the left hand side of comparison [-Wlogical-not-parentheses]
>
> if (!vrng->conf.period_ms > 0) {
> error_setg(errp, "'period' parameter expects a positive integer");
> return;
> }
>
> Maybe better code
>
> if (vrng->conf.period_ms <= 0) {
> error_setg(errp, "'period' parameter expects a positive integer");
> return;
> }
Thanks!
Do you want to submit a patch, since you've identified the fix as
well?
Amit
next prev parent reply other threads:[~2014-11-18 8:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-17 17:15 [Qemu-devel] [Bug 1393486] [NEW] hw/virtio/virtio-rng.c:150: bad test ? dcb
2014-11-18 8:41 ` Amit Shah [this message]
2016-06-23 8:40 ` [Qemu-devel] [Bug 1393486] " T. Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141118084139.GA9190@grmbl.mre \
--to=amit.shah@redhat.com \
--cc=1393486@bugs.launchpad.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).